SiStripHitEfficiencyWorker: adding consecutive missing hits recovery when one of the two hits is in an inactive module

[mmusich]

PR description:

The goal of this PR is apply the correction introduced in PR #44858 to the SiStripHitEfficiencyWorker module which is run as part of the PromptCalibProdSiStripHitEff Prompt Calibration Loop workflows.
Features introduced (as per #44858 (comment)):

• Improvement of the missing hits recovery within the strips, to take into account two consecutive missing hits when one is located in an inactive modules;
• Expected output is a slight change in the hit efficiency per layer, as shown in the slides presented during the Strip calibration and local reconstruction meeting here ( Recovery of consecutive missing hits )

PR validation:

I've run the following script with and without this PR:

#!/bin/bash -ex

# CMSSW_14_1_X_2024-05-20-2300
# voms-proxy-init -voms cms

cmsDriver.py stepReAlCa \
	     -s ALCA:PromptCalibProdSiStripHitEff \
	     --conditions 130X_dataRun3_Express_v2 \
	     --scenario pp \
	     --data \
	     --era Run3 \
	     --datatier ALCARECO \
	     --eventcontent ALCARECO \
	     --processName=ReAlCa \
	     -n 100000 \
	     --dasquery='file dataset=/StreamExpress/Run2023C-SiStripCalMinBias-Express-v4/ALCARECO run=368724' \
	     --nThreads=4

cmsDriver.py stepHarvest \
	     -s ALCAHARVEST:SiStripHitEff \
	     --conditions 130X_dataRun3_Express_v2 \
	     --scenario pp \
	     --data \
	     --era Run3 \
	     --filein file:PromptCalibProdSiStripHitEff.root \
	     -n -1

and compared the ouptut:

• for good modules only:

• for all modules:
  

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported together with #44858 to CMSSW_14_0_X for data-taking purposes.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45008/40289

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @saumyaphor4252, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@yuanchao, @robervalwalsh, @rsreds, @gbenelli, @echabert, @mmusich, @tocheng this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflows = 1001, 1001.2, 1001.3, 1001.4, 1002.3

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2f477/39446/summary.html
COMMIT: 4288574
CMSSW: CMSSW_14_1_X_2024-05-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45008/39446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 21 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3368854
• DQMHistoTests: Total failures: 857
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3367977
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 169 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• The updates are identical to those already merged (in another class) with Computation of silicon strip hit efficiency : Consecutive missing hits recovery #44858
• No issue are visible in the PR tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1