Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Fix multiple RelVals errors with Unknown trigger name exception #44918

Merged
merged 4 commits into from
May 13, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 7, 2024

backport of #44932
backport of #44925
backport of #44914

PR description:

Title says it all, minor technical fixes to avoid relval failures in IB.
No regression expected. Backporting to 14.0.X for the sake of having clean relvals in the data-taking release even if these are not failing in the 14.0.X IB.

PR validation:

Now runTheMatrix.py -l 1001.3,1040.1,1041.0,1042.0 -t 4 -j 8 --ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim combined backport from #44914, #44925 and #44932 to the data-taking release of 2024.

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@sunilUIET, @cmsbuild, @miquork, @subirsarkar, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @Martin-Grunewald, @slomeo, @makortel this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32eee4/39278/summary.html
COMMIT: fb4ceba
CMSSW: CMSSW_14_0_X_2024-05-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44918/39278/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

  • 2500.22500.2_NANOmc124Xrun3/step2_NANOmc124Xrun3.log

Comparison Summary

Summary:

  • You potentially added 82 lines to the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326485
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326462
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

Pull request #44918 was updated. @miquork, @sunilUIET, @subirsarkar, @srimanob, @AdrianoDee, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

test parameters:

  • enable_tests = threading
  • workflows_threading = 1001.3, 1040, 1040.1, 1041.0, 1042.0

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

Pull request #44918 was updated. @cmsbuild, @sunilUIET, @miquork, @AdrianoDee, @subirsarkar, @srimanob can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32eee4/39307/summary.html
COMMIT: ef8d82f
CMSSW: CMSSW_14_0_X_2024-05-08-1100/el8_amd64_gcc12
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44918/39307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 28 lines from the logs
  • Reco comparison results: 152 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3327413
  • DQMHistoTests: Total failures: 2735
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3324657
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 04f86e1 into cms-sw:CMSSW_14_0_X May 13, 2024
12 checks passed
@mmusich mmusich deleted the fix_Unknown_trigger_name_14_0_X branch May 14, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants