Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple RelVals errors with Unknown trigger name exception #44914

Merged
merged 2 commits into from
May 7, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 7, 2024

fixes #44895

PR description:

Title says it all, minor technical fixes to avoid relval failures in IB.
No regression expected.

PR validation:

Now runTheMatrix.py -l 1001.3,1040.1,1041.0,1042.0 -t 4 -j 8 --ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

cms-bot internal usage

@mmusich mmusich changed the title Fix multiple RelVals errorw with Unknown trigger name exception Fix multiple RelVals errors with Unknown trigger name exception May 7, 2024
@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

test parameters:

  • enable_tests = threading
  • workflows_threading = 1001.3, 1040.1, 1041.0, 1042.0

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44914/40193

  • This PR adds an extra 60KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@miquork, @subirsarkar, @sunilUIET, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@makortel, @slomeo, @fabiocos, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c49d9/39273/summary.html
COMMIT: be9f500
CMSSW: CMSSW_14_1_X_2024-05-06-2300/el8_amd64_gcc12
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44914/39273/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332453
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

srimanob commented May 7, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8391245 into cms-sw:master May 7, 2024
13 checks passed
@mmusich mmusich deleted the fix_Unknown_trigger_name branch May 7, 2024 15:20
@@ -2463,7 +2463,7 @@ def lhegensim2018ml(fragment,howMuch):
'--datatier':'ALCARECO',
'--eventcontent':'ALCARECO',
'--conditions':'auto:run2_data',
'--triggerResultsProcess':'RECO',
'--triggerResultsProcess':'ALCARECO',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich can you explain, just for my understanding what is the difference here between ALCARECO and RECO ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grzanka none, it's a convention, but you need to keep it in synch with the one you used in the step before:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation. Does it mean that following this convention makes this PR to fix the reported issue ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that following this convention makes this PR to fix the reported issue ?

Yes, because now the TriggerResults are read from the right module label, thus the path required in the following step is found.
You can see that the fix is effective because the failing workflows now run fine in the test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple RelVals: Unknown trigger name exception
6 participants