-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple RelVals errors with Unknown trigger name
exception
#44914
Conversation
cms-bot internal usage |
Unknown trigger name
exception Unknown trigger name
exception
test parameters:
|
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44914/40193
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@miquork, @subirsarkar, @sunilUIET, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c49d9/39273/summary.html Comparison SummarySummary:
|
+pdmv |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@@ -2463,7 +2463,7 @@ def lhegensim2018ml(fragment,howMuch): | |||
'--datatier':'ALCARECO', | |||
'--eventcontent':'ALCARECO', | |||
'--conditions':'auto:run2_data', | |||
'--triggerResultsProcess':'RECO', | |||
'--triggerResultsProcess':'ALCARECO', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich can you explain, just for my understanding what is the difference here between ALCARECO and RECO ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grzanka none, it's a convention, but you need to keep it in synch with the one you used in the step before:
'--process':'ALCARECO', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explanation. Does it mean that following this convention makes this PR to fix the reported issue ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that following this convention makes this PR to fix the reported issue ?
Yes, because now the TriggerResults
are read from the right module label, thus the path
required in the following step is found.
You can see that the fix is effective because the failing workflows now run fine in the test results
fixes #44895
PR description:
Title says it all, minor technical fixes to avoid relval failures in IB.
No regression expected.
PR validation:
Now
runTheMatrix.py -l 1001.3,1040.1,1041.0,1042.0 -t 4 -j 8 --ibeos
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A