Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserving autoNano ordering #44909

Merged
merged 1 commit into from
May 9, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented May 6, 2024

PR description:

the original implementation of the autoNano mapping does not preserve the order in which the sequence and customisation are configured in the autoNano.py dictionary. This PR remedies this

PR validation:

nano workflow 2500.403_jmeNANOmc132X

thanks @nurfikri89 for notifying us

@vlimant
Copy link
Contributor Author

vlimant commented May 6, 2024

enable nano

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44909/40185

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

A new Pull Request was created by @vlimant for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented May 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4b6d7/39265/summary.html
COMMIT: 199f9ab
CMSSW: CMSSW_14_1_X_2024-05-06-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44909/39265/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332453
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.39 3.48 -2.7% 2.264 2.190
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.05 3.11 -1.9% 2.692 2.634
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.15 3.25 -3.0% 2.680 2.623
2500.01 1.446 1.446 0.000 ( +0.0% ) 5.67 6.00 -5.4% 2.369 2.314
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.17 3.25 -2.4% 2.562 2.469
2500.012 1.761 1.761 0.000 ( +0.0% ) 4.59 4.70 -2.3% 2.474 2.386
2500.1 2.353 2.353 0.000 ( +0.0% ) 4.26 4.44 -4.0% 2.077 2.071
2500.2 2.448 2.448 0.000 ( +0.0% ) 4.85 5.02 -3.4% 1.996 1.872
2500.21 1.285 1.285 0.000 ( +0.0% ) 3.33 3.40 -2.2% 2.274 2.281
2500.211 1.668 1.668 0.000 ( +0.0% ) 2.92 3.07 -5.0% 2.362 2.348
2500.3 2.229 2.229 0.000 ( +0.0% ) 8.88 9.45 -6.0% 1.977 1.971
2500.301 2.833 2.833 0.000 ( +0.0% ) 7.97 8.53 -6.6% 1.957 1.962
2500.31 7.164 7.164 0.000 ( +0.0% ) 1.29 1.44 -10.4% 1.707 1.699
2500.311 1.568 1.568 0.000 ( +0.0% ) 7.87 8.54 -7.8% 1.064 1.051
2500.312 540.457 540.457 0.000 ( +0.0% ) 0.47 0.50 -7.3% 1.597 1.620
2500.313 817.694 817.694 0.000 ( +0.0% ) 0.65 0.71 -7.6% 1.596 1.607
2500.32 1.348 1.348 0.000 ( +0.0% ) 11.39 11.96 -4.7% 2.375 2.256
2500.321 1.757 1.757 0.000 ( +0.0% ) 9.79 10.21 -4.1% 2.449 2.411
2500.322 1.236 1.236 0.000 ( +0.0% ) 9.60 9.95 -3.5% 2.213 2.081
2500.323 7.772 7.772 0.000 ( +0.0% ) 3.82 4.02 -5.0% 1.922 1.937
2500.324 1.874 1.874 0.000 ( +0.0% ) 9.69 10.05 -3.6% 2.194 2.164
2500.325 4.136 4.136 0.000 ( +0.0% ) 4.15 4.40 -5.6% 2.186 2.176
2500.326 3.342 3.342 0.000 ( +0.0% ) 1.52 1.62 -6.4% 2.120 2.151
2500.327 1.811 1.811 0.000 ( +0.0% ) 9.77 10.20 -4.2% 2.330 2.145
2500.4 2.374 2.374 0.000 ( +0.0% ) 8.55 8.99 -4.9% 1.860 1.808
2500.401 1.891 1.891 0.000 ( +0.0% ) 7.65 8.19 -6.6% 1.710 1.705
2500.402 2.950 2.950 0.000 ( +0.0% ) 7.72 8.09 -4.6% 1.787 1.770
2500.403 8.700 8.700 0.000 ( +0.0% ) 2.76 2.90 -4.9% 1.791 1.781
2500.404 5.474 5.474 0.000 ( +0.0% ) 1.12 1.18 -5.9% 1.846 1.810
2500.405 2.860 2.860 0.000 ( +0.0% ) 7.82 8.20 -4.7% 1.912 1.776
2500.5 5.194 5.194 0.000 ( +0.0% ) 14.64 15.72 -6.9% 1.523 1.519
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.07 9.62 -5.7% 1.475 1.477

@vlimant
Copy link
Contributor Author

vlimant commented May 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 24dd913 into cms-sw:master May 9, 2024
13 checks passed
@vlimant vlimant deleted the autonano_ordering_master branch June 12, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants