Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserving autoNano ordering [14.0.X] #44908

Merged
merged 1 commit into from
May 13, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented May 6, 2024

PR description:

the original implementation of the autoNano mapping does not preserve the order in which the sequence and customisation are configured in the autoNano.py dictionary. This PR remedies this

PR validation:

nano workflow 2500.403_jmeNANOmc132X

thanks @nurfikri89 for notifying us

backport of #44909

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

A new Pull Request was created by @vlimant for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

cms-bot internal usage

@vlimant vlimant mentioned this pull request May 6, 2024
@vlimant vlimant changed the title preserving autoNano ordering preserving autoNano ordering [14.0.X] May 6, 2024
@vlimant
Copy link
Contributor Author

vlimant commented May 6, 2024

enable nano

@vlimant
Copy link
Contributor Author

vlimant commented May 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68ce3b/39260/summary.html
COMMIT: b158dcc
CMSSW: CMSSW_14_0_X_2024-05-06-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44908/39260/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 49 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.87 3.98 -2.9% 2.151 2.176
2500.001 2.897 2.897 0.000 ( +0.0% ) 3.48 3.57 -2.5% 2.565 2.581
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.63 3.71 -1.9% 2.550 2.553
2500.01 1.446 1.446 0.000 ( +0.0% ) 6.72 6.98 -3.8% 2.260 2.273
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.64 3.70 -1.7% 2.448 2.420
2500.012 1.761 1.761 0.000 ( +0.0% ) 5.24 5.37 -2.5% 2.344 2.355
2500.1 2.354 2.354 0.000 ( +0.0% ) 5.10 5.19 -1.8% 2.006 2.074
2500.2 2.448 2.448 0.000 ( +0.0% ) 5.87 5.92 -0.8% 1.885 1.865
2500.21 1.286 1.286 0.000 ( +0.0% ) 4.18 4.26 -1.7% 2.285 2.294
2500.211 1.668 1.668 0.000 ( +0.0% ) 3.71 3.88 -4.6% 2.199 2.367
2500.3 2.229 2.229 0.000 ( +0.0% ) 11.54 12.30 -6.2% 1.979 1.975
2500.301 2.833 2.833 0.000 ( +0.0% ) 10.38 10.97 -5.4% 1.966 1.961
2500.31 1.348 1.348 0.000 ( +0.0% ) 18.94 19.81 -4.4% 2.368 2.367
2500.311 1.757 1.757 0.000 ( +0.0% ) 15.17 15.43 -1.7% 2.358 2.443
2500.312 7.164 7.164 0.000 ( +0.0% ) 1.47 1.54 -4.9% 1.697 1.692
2500.313 1.568 1.568 0.000 ( +0.0% ) 7.06 9.09 -22.4% 1.050 1.047
2500.314 1.236 1.236 0.000 ( +0.0% ) 13.91 14.97 -7.1% 2.151 2.235
2500.315 1.874 1.874 0.000 ( +0.0% ) 14.58 15.30 -4.7% 2.340 2.342
2500.316 3.342 3.342 0.000 ( +0.0% ) 1.99 2.12 -6.0% 1.841 2.281
2500.317 1.811 1.811 0.000 ( +0.0% ) 14.15 14.60 -3.1% 2.317 2.199
2500.318 4.136 4.136 0.000 ( +0.0% ) 5.54 5.80 -4.5% 2.194 2.166
2500.4 2.374 2.374 0.000 ( +0.0% ) 11.19 12.15 -7.9% 1.884 1.922
2500.401 1.885 1.885 0.000 ( +0.0% ) 9.77 10.49 -6.9% 1.690 1.740
2500.402 2.950 2.950 0.000 ( +0.0% ) 9.37 10.40 -9.9% 1.659 1.711
2500.403 5.474 5.474 0.000 ( +0.0% ) 1.42 1.46 -3.2% 1.805 1.817
2500.404 2.860 2.860 0.000 ( +0.0% ) 9.99 10.57 -5.5% 1.854 1.908
2500.405 8.700 8.700 0.000 ( +0.0% ) 3.53 3.68 -4.0% 1.911 1.890
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.78 16.27 -3.0% 1.664 1.551
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.70 9.91 -2.1% 1.531 1.614

@vlimant
Copy link
Contributor Author

vlimant commented May 13, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 19a436a into cms-sw:CMSSW_14_0_X May 13, 2024
12 checks passed
@vlimant vlimant deleted the autonano_ordering branch June 12, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants