Fix position of unconstrained pT coming from OMTF (backport for 14_0_X)

[dinyar]

PR description:

Due to a miscommunication the incoming unconstrained pT from OMTF as expected at the wrong position in the bitword on the link. This PR fixes this.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44798

[cmsbuild]

A new Pull Request was created by @dinyar for CMSSW_14_0_X.

It involves the following packages:

• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@JanFSchulte, @eyigitba, @Martin-Grunewald, @missirol, @thomreis this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix position of unconstrained pT coming from OMTF #44798

[cmsbuild]

cms-bot internal usage

[aloeliger]

type bug-fix

[aloeliger]

backport of #44798

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe884d/38993/summary.html
COMMIT: 244e09f
CMSSW: CMSSW_14_0_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44799/38993/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/L1Trigger/L1TMuon/src/MuonTriggerPrimitive.cc
>> Compiling  src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc
>> Compiling  src/L1Trigger/L1TMuon/src/SubsystemCollector.cc
>> Compiling  src/L1Trigger/L1TMuon/src/SubsystemCollectorFactory.cc
src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc: In static member function 'static void l1t::RegionalMuonRawDigiTranslator::generatePackedDataWords(const l1t::RegionalMuonCand&, uint32_t&, uint32_t&, bool, bool, bool)':
src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:191:41: error: no matching function for call to 'l1t::RegionalMuonRawDigiTranslator::generateRawTrkAddress(const l1t::RegionalMuonCand&, const bool&, const bool&)'
  191 |   int rawTrkAddr = generateRawTrkAddress(mu, isKbmtf, useOmtfDisplacementInfo);
      |                    ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-04-22-1100/src/L1Trigger/L1TMuon/interface/RegionalMuonRawDigiTranslator.h:45:16: note: candidate: 'static int l1t::RegionalMuonRawDigiTranslator::generateRawTrkAddress(const l1t::RegionalMuonCand&, bool)'
   45 |     static int generateRawTrkAddress(const RegionalMuonCand&, bool isKalman);


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package L1Trigger/L1TMuon
>> Compile sequence completed for CMSSW CMSSW_14_0_X_2024-04-22-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-04-22-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package L1Trigger/L1TMuon
Entering library rule at src/L1Trigger/L1TMuon/plugins
>> Compiling edm plugin src/L1Trigger/L1TMuon/plugins/CSCCollector.cc


[cmsbuild]

Pull request #44799 was updated. @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe884d/39009/summary.html
COMMIT: 7cf527b
CMSSW: CMSSW_14_0_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44799/39009/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 91 lines from the logs
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3318486
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3318463
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1