Fix position of unconstrained pT coming from OMTF

[dinyar]

PR description:

Due to a miscommunication the incoming unconstrained pT from OMTF as expected at the wrong position in the bitword on the link. This PR fixes this. (A backport will be needed to fix DQM mismatches.)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44798/40035

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dinyar for master.

It involves the following packages:

• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@thomreis, @Martin-Grunewald, @JanFSchulte, @eyigitba, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

type bug-fix

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8448b/38992/summary.html
COMMIT: f41ee91
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44798/38992/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/L1Trigger/L1TMuon/src/MuonTriggerPrimitive.cc
>> Compiling  src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc
>> Compiling  src/L1Trigger/L1TMuon/src/SubsystemCollector.cc
>> Compiling  src/L1Trigger/L1TMuon/src/SubsystemCollectorFactory.cc
src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc: In static member function 'static void l1t::RegionalMuonRawDigiTranslator::generatePackedDataWords(const l1t::RegionalMuonCand&, uint32_t&, uint32_t&, bool, bool, bool)':
src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:191:41: error: no matching function for call to 'l1t::RegionalMuonRawDigiTranslator::generateRawTrkAddress(const l1t::RegionalMuonCand&, const bool&, const bool&)'
  191 |   int rawTrkAddr = generateRawTrkAddress(mu, isKbmtf, useOmtfDisplacementInfo);
      |                    ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/L1Trigger/L1TMuon/src/RegionalMuonRawDigiTranslator.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-22-1100/src/L1Trigger/L1TMuon/interface/RegionalMuonRawDigiTranslator.h:45:16: note: candidate: 'static int l1t::RegionalMuonRawDigiTranslator::generateRawTrkAddress(const l1t::RegionalMuonCand&, bool)'
   45 |     static int generateRawTrkAddress(const RegionalMuonCand&, bool isKalman);


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package L1Trigger/L1TMuon
>> Compile sequence completed for CMSSW CMSSW_14_1_X_2024-04-22-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-22-1100/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package L1Trigger/L1TMuon
Entering library rule at src/L1Trigger/L1TMuon/plugins
>> Compiling edm plugin src/L1Trigger/L1TMuon/plugins/L1TBMTFConverter.cc


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44798/40038

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #44798 was updated. @epalencia, @aloeliger, @cmsbuild can you please check and sign again.

[epalencia]

Please test

[missirol]

Hi @dinyar

Just a naive question, for my own understanding.

Is it correct that this PR is relevant to online-dqm, but it does not affect the unpacking of L1T data that we do online at HLT [1] (so, the online HLT is blind to this specific PR) ?

Thanks
Marino

[1]

process.hltGtStage2Digis = cms.EDProducer( "L1TRawToDigi",
    FedIds = cms.vint32( 1404 ),
    Setup = cms.string( "stage2::GTSetup" ),
    FWId = cms.uint32( 0 ),
    DmxFWId = cms.uint32( 0 ),
    FWOverride = cms.bool( False ),
    TMTCheck = cms.bool( True ),
    CTP7 = cms.untracked.bool( False ),
    MTF7 = cms.untracked.bool( False ),
    InputLabel = cms.InputTag( "rawDataCollector" ),
    lenSlinkHeader = cms.untracked.int32( 8 ),
    lenSlinkTrailer = cms.untracked.int32( 8 ),
    lenAMCHeader = cms.untracked.int32( 8 ),
    lenAMCTrailer = cms.untracked.int32( 0 ),
    lenAMC13Header = cms.untracked.int32( 8 ),
    lenAMC13Trailer = cms.untracked.int32( 8 ),
    debug = cms.untracked.bool( False ),
    MinFeds = cms.uint32( 0 )
)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8448b/39000/summary.html
COMMIT: 2437873
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44798/39000/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 96 lines from the logs
• Reco comparison results: 36 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319832
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[dinyar]

Hi @dinyar

Just a naive question, for my own understanding.

Is it correct that this PR is relevant to online-dqm, but it does not affect the unpacking of L1T data that we do online at HLT [1] (so, the online HLT is blind to this specific PR) ?

Thanks Marino

hi @missirol,

yes, exactly. this should only affect DQM but not HLT.

Cheers,
Dinyar

[dinyar]

Briefly discussed with @kbunkow whether the emulator should re-emulate the faulty behaviour for those data that were taken like that, the outcome of it was that it shouldn't (as is currently done in the PR), so this is ready to merge.

[eyigitba]

Hi Dinyar, since we didn't collect any data with the displaced OMTF algorithm I also think that it should be fine like this. Thanks

[aloeliger]

As far as I am concerned, this change is trivial and can go in immediately. @dinyar @eyigitba Any final expected changes?

[dinyar]

No, from my side this is ready to go. Thanks!

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1