-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LumiPixelsMinBias to Run1/2 Tier0Exp step #44787
Add LumiPixelsMinBias to Run1/2 Tier0Exp step #44787
Conversation
cms-bot internal usage |
please test workflows 1001,1001.2 with #44767 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44787/40023
|
A new Pull Request was created by @perrotta for master. It involves the following packages:
@AdrianoDee, @subirsarkar, @sunilUIET, @srimanob, @miquork can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21edb3/38972/summary.html Comparison SummarySummary:
|
type bugfix |
fixes #44780 |
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you please review and sign? Thanks! |
+pdmv |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
This does not need to wait for #44767, correct? |
Not at all! |
Thanks. |
+1 |
PR description:
As noticed in #44780 , the path pathALCARECOLumiPixelsMinBias is defined in the step2 (RECO), but the path is not part the the process.schedule.
This PR adds LumiPixelsMinBias to the TIER0EXP and TIER0EXPRUN2 steps, as suggested by @makortel in #44780
See also #44780 (comment)
PR validation:
Run wfs 1001 and 1001.2 together with #44767, and the fatal exception reported in #44767 (comment) is not there any more