Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UPC relval workflows #44671

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR updates the Starlight gridpack to fix the issue seen in #44536 . In addition it updates the 2024 UPC relval workflows by switching to the HI 2024 GT and the 2023 HI workflows by changing the beamspot to Realistic2023PbPbCollision and the HLT key to HIon (as used in central HIN 2023 MC production).

PR validation:

Tested the relval workflows 180, 180.1, 181, 181.1 locally.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44671/39870

  • This PR adds an extra 84KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @SiewYan, @AdrianoDee, @alberto-sanchez, @miquork, @subirsarkar, @GurpreetSinghChahal, @bbilin, @mkirsano, @menglu21, @cmsbuild, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @slomeo, @makortel, @fabiocos this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test workflow 180, 180.1, 181, 181.1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09f688/38793/summary.html
COMMIT: 5494d70
CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44671/38793/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 20 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1699 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3524833
  • DQMHistoTests: Total failures: 4878
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3519931
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 191.744 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 181.0 ): 111.859 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 181.0 ): 75.433 KiB GEM/Digis
  • DQMHistoSizes: changed ( 181.0 ): 1.781 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 181.0 ): 1.094 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 181.0 ): 0.614 KiB GEM/SimHits
  • DQMHistoSizes: changed ( 181.0 ): 0.531 KiB GEM/Pad
  • DQMHistoSizes: changed ( 181.0 ): 0.432 KiB GEM/PadCluster
  • Checked 212 log files, 173 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@stahlleiton
Copy link
Contributor Author

Are there any comments on this PR?

@stahlleiton
Copy link
Contributor Author

@cms-sw/pdmv-l2 , @cms-sw/generators-l2 , @cms-sw/upgrade-l2 : please review/sign this PR

@menglu21
Copy link
Contributor

+1

@AdrianoDee
Copy link
Contributor

+pdmv

@AdrianoDee
Copy link
Contributor

please test
(just because the tests are 2 weeks old)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09f688/39032/summary.html
COMMIT: 5494d70
CMSSW: CMSSW_14_1_X_2024-04-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44671/39032/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 93 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3319852
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3319829
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit af91cef into cms-sw:master Apr 24, 2024
11 checks passed
@makortel
Copy link
Contributor

The workflows 180.1 and 181.1 added in this PR frequently (but not always) fail with

---- Begin Fatal Exception 26-Apr-2024 10:58:14 CEST-----------------------
An exception of category 'Conditions not found' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 8 stream: 1
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module SiStripDigiToRawModule/'SiStripDigiToRaw'
   [5] Calling method for module MixingModule/'mix'
Exception Message:
Unavailable Conditions of type HcalMCParams for cell (0x54000140) (Det 5:5 subdet 2:2 ZDC+ UNKNOWN 0,0)
----- End Fatal Exception -------------------------------------------------

There is already an older issue #43582 about this failure mode, so I'd suggest to follow up there.

@stahlleiton stahlleiton deleted the UPC_relval_CMSSW_14_1_X branch June 14, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants