Fix for EndPaths in DependecyGraph

[AdrianoDee]

PR description:

Trivial fix for DependencyGraph when looping on EndPaths. Spotted because when there are more EndPaths than Paths it throws:

std::bad_alloc exception
----- Begin Fatal Exception 15-Apr-2024 16:51:10 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Calling beginJob
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

To test one can run:

cmsDriver.py step3 -s RAW2DIGI:RawToDigi_pixelOnly,RECO:reconstruction_pixelTrackingOnly,VALIDATION:@pixelTrackingOnlyValidation,DQM:@pixelTrackingOnlyDQM --conditions 140X_mcRun3_2023_realistic_v3 --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3_2023 --filein /store/relval/CMSSW_14_0_0/RelValSingleMuPt10/GEN-SIM-DIGI-RAW/140X_mcRun3_2023_realistic_v3_STD_2023_noPU-v1/2580000/34fca56a-1726-4a1a-b607-a23588c76f5c.root --fileout file:step3.root --python_filename step3_pixel.py --customise_commands 'process.load("FWCore.Services.DependencyGraph_cfi")'

that will crash in master and with this PR will produce this (unreadable but correct) graph:

[AdrianoDee]

type bug-fix

[cmsbuild]

cms-bot internal usage

[AdrianoDee]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44742/39957

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• FWCore/Services (core)

@smuzaffar, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @makortel, @missirol, @fwyzard this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Thanks!

[AdrianoDee]

Thanks!

You're welcome ( :

[makortel]

@cmsbuild, please test

[fwyzard]

thanks @AdrianoDee - could you prepare also a 14.0.x backport ?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eeaff/38857/summary.html
COMMIT: fe309a5
CMSSW: CMSSW_14_1_X_2024-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44742/38857/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 63 lines from the logs
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319475
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319449
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

Comparisons show the usual

• Non reproducibility in wf 136.793 #43293
• Non-reproducibility in TriggerResults in 24834.0, 24834.911, and 25034.999 #43790

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1