Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Updates in Alignment/OfflineValidation used in Run3 re-reco validations #44731

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 12, 2024

backport of #44704

PR description:

This PR features some miscellaneous updates in different plugins used for Tracker Alignment validations that have been accumulated while operating the validation package in the process of checking the alignment for the 2022-2023 data re-reconstruction:

  • adds 2D plots of mass vs muon kinematics in eta bins in DiMuonValidation
  • re-factor impact parameter profile plots, add IP error profiles vs track kinematic in GeneralPurposeVertexAnalyzer
  • fixes in ShortenedTrackValidation , adjust the plot axis ranges and input tag of the original track collection (post-refit)
  • improves DiMuonVertexValidation by adding several more control plots.

PR validation:

Passes unit tests of the package and extensive private validations.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44704 to CMSSW_14_0_X (2024 data-taking release)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@consuegs, @perrotta, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@tlampen, @tocheng, @mmusich, @yuanchao, @rsreds, @adewit this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-621a0e/38826/summary.html
COMMIT: 88b10e5
CMSSW: CMSSW_14_0_X_2024-04-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44731/38826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

  • Verbatim backport of the PR already merged in master

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3a82e07 into cms-sw:CMSSW_14_0_X Apr 15, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_improveAliOffflineValidation_14_0_X branch April 15, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants