-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates in Alignment/OfflineValidation used in Run3 re-reco validations #44704
Updates in Alignment/OfflineValidation used in Run3 re-reco validations #44704
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44704/39910
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@perrotta, @cmsbuild, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c415d/38780/summary.html Comparison SummarySummary:
|
- also use enum Variable for counting elements in vectors
0378128
to
e801157
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44704/39927
|
Pull request #44704 was updated. @consuegs, @cmsbuild, @saumyaphor4252, @perrotta can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c415d/38812/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR features some miscellaneous updates in different plugins used for Tracker Alignment validations that have been accumulated while operating the validation package in the process of checking the alignment for the 2022-2023 data re-reconstruction:
DiMuonValidation
GeneralPurposeVertexAnalyzer
ShortenedTrackValidation
, adjust the plot axis ranges and input tag of the original track collection (post-refit)DiMuonVertexValidation
by adding several more control plots.PR validation:
Passes unit tests of the package and extensive private validations.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported to the data-taking release cycle (CMSSW_14_0_X).