Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Backport of 44507+44726 (Add ParticleNet legacy discriminator scores and mass regression to MINIAOD) #44716

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Apr 11, 2024

PR description:

Backport of:

PR description:

Add back the ParticleNet legacy discriminator scores and mass regression for AK8 Jets. This allows a comparison with newer version of ParticleNet and may be useful in scenarios that fall out of the phase space of the newer ParticleNet training.

  • Changes expected in the miniAOD and nanoAOD output. Added the following branches to nanoAOD:
 FatJet_particleNetLegacy_QCD
 FatJet_particleNetLegacy_Xbb
 FatJet_particleNetLegacy_Xcc 
 FatJet_particleNetLegacy_Xqq 
 FatJet_particleNetLegacy_mass 

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

A new Pull Request was created by @hqucms for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @hqucms, @mandrenguyen, @vlimant, @jfernan2 can you please review it and eventually sign? Thanks.
@mbluj, @rappoccio, @AlexDeMoor, @demuller, @andrzejnovak, @mariadalfonso, @gkasieczka, @nhanvtran, @jdolen, @schoef, @mmarionncern, @gpetruc, @ahinzmann, @gouskos, @hatakeyamak, @jdamgov, @azotz, @castaned, @Ming-Yan, @seemasharmafnal, @Senphy, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented Apr 11, 2024

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Apr 11, 2024

please test

@hqucms
Copy link
Contributor Author

hqucms commented Apr 11, 2024

backport of #44507

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04b19/38795/summary.html
COMMIT: 40c55c9
CMSSW: CMSSW_14_0_X_2024-04-11-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44716/38795/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 105 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2390 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308451
  • DQMHistoTests: Total failures: 1189
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307242
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16464
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 -0.000 ( -0.0% ) 5.15 5.22 -1.3% 2.143 2.219
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.63 4.69 -1.3% 2.565 2.596
2500.002 2.643 2.643 -0.001 ( -0.0% ) 4.78 4.87 -2.0% 2.570 2.596
2500.01 1.318 1.318 -0.000 ( -0.0% ) 9.09 9.69 -6.2% 2.260 2.296
2500.011 1.739 1.740 -0.001 ( -0.1% ) 5.04 5.24 -3.9% 2.403 2.459
2500.012 1.580 1.581 -0.000 ( -0.0% ) 7.19 7.46 -3.7% 2.321 2.374
2500.1 2.197 2.197 0.000 ( +0.0% ) 5.15 5.26 -2.0% 2.003 2.071
2500.2 2.314 2.314 0.000 ( +0.0% ) 5.85 6.01 -2.7% 1.898 1.983
2500.21 1.182 1.182 0.000 ( +0.0% ) 4.22 4.29 -1.5% 2.185 2.270
2500.211 1.546 1.546 0.000 ( +0.0% ) 3.57 3.75 -4.8% 2.189 2.357
2500.3 2.070 2.065 0.006 ( +0.3% ) 11.74 12.47 -5.8% 1.909 1.973
2500.301 2.644 2.637 0.007 ( +0.3% ) 9.75 10.20 -4.4% 1.842 1.957
2500.31 1.256 1.255 0.001 ( +0.1% ) 18.59 19.98 -6.9% 2.280 2.353
2500.311 1.643 1.641 0.002 ( +0.1% ) 12.96 13.36 -3.0% 2.303 2.453
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.40 1.34 +4.7% 1.698 1.698
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.93 6.50 +6.5% 1.052 1.050
2500.314 1.163 1.163 0.000 ( +0.0% ) 12.97 13.95 -7.0% 2.177 2.151
2500.315 1.759 1.757 0.002 ( +0.1% ) 12.94 14.25 -9.1% 2.331 2.331
2500.316 3.095 3.093 0.002 ( +0.1% ) 2.14 2.24 -4.8% 2.122 2.273
2500.317 1.791 1.788 0.002 ( +0.1% ) 12.73 13.75 -7.4% 2.260 2.167
2500.4 2.229 2.226 0.003 ( +0.1% ) 11.32 12.14 -6.7% 1.886 1.883
2500.401 1.749 1.749 0.000 ( +0.0% ) 9.77 10.47 -6.7% 1.816 1.737
2500.402 2.773 2.770 0.003 ( +0.1% ) 9.32 10.16 -8.2% 1.748 1.786
2500.403 5.083 5.080 0.003 ( +0.1% ) 1.54 1.61 -4.2% 1.930 1.938
2500.404 2.781 2.778 0.003 ( +0.1% ) 8.86 9.95 -10.9% 1.832 1.902
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.28 15.98 -4.4% 1.615 1.627
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.56 9.69 -1.3% 1.659 1.660

@cmsbuild
Copy link
Contributor

Pull request #44716 was updated. @mandrenguyen, @hqucms, @cmsbuild, @vlimant, @jfernan2 can you please check and sign again.

@hqucms
Copy link
Contributor Author

hqucms commented Apr 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a04b19/38820/summary.html
COMMIT: c089fd4
CMSSW: CMSSW_14_0_X_2024-04-12-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44716/38820/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 98 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2388 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308451
  • DQMHistoTests: Total failures: 1180
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307251
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16470
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 0.000 ( +0.0% ) 5.12 5.19 -1.3% 2.232 2.158
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.61 4.67 -1.1% 2.644 2.594
2500.002 2.643 2.643 0.000 ( +0.0% ) 4.74 4.84 -2.1% 2.550 2.575
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.21 9.41 -2.2% 2.289 2.265
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.12 5.13 -0.2% 2.446 2.425
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.21 7.28 -1.0% 2.356 2.318
2500.1 2.197 2.197 0.000 ( +0.0% ) 5.18 5.23 -0.9% 2.075 2.006
2500.2 2.314 2.314 0.000 ( +0.0% ) 5.92 5.97 -0.9% 1.988 1.894
2500.21 1.182 1.182 0.000 ( +0.0% ) 4.23 4.27 -1.1% 2.269 2.183
2500.211 1.546 1.546 0.000 ( +0.0% ) 3.57 3.66 -2.3% 2.347 2.191
2500.3 2.070 2.065 0.006 ( +0.3% ) 11.87 12.39 -4.2% 1.975 1.905
2500.301 2.644 2.637 0.007 ( +0.3% ) 9.87 10.15 -2.8% 1.964 1.845
2500.31 1.256 1.255 0.001 ( +0.1% ) 18.72 19.92 -6.0% 2.345 2.273
2500.311 1.643 1.641 0.002 ( +0.1% ) 13.24 13.45 -1.6% 2.427 2.326
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.17 1.39 -16.0% 1.698 1.696
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.34 7.18 -11.7% 1.057 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 12.67 13.78 -8.1% 2.232 2.195
2500.315 1.759 1.757 0.002 ( +0.1% ) 13.49 14.19 -5.0% 2.335 2.335
2500.316 3.095 3.093 0.002 ( +0.1% ) 2.13 2.16 -1.4% 2.286 2.157
2500.317 1.791 1.788 0.002 ( +0.1% ) 12.85 13.46 -4.6% 2.174 2.179
2500.4 2.229 2.226 0.003 ( +0.1% ) 11.36 12.04 -5.6% 1.892 1.886
2500.401 1.749 1.749 0.000 ( +0.0% ) 9.86 10.33 -4.5% 1.822 1.717
2500.402 2.773 2.770 0.003 ( +0.1% ) 9.51 9.99 -4.8% 1.786 1.763
2500.403 5.083 5.080 0.003 ( +0.1% ) 1.54 1.61 -4.3% 1.816 1.813
2500.404 2.781 2.778 0.003 ( +0.1% ) 9.43 9.78 -3.6% 1.919 1.831
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.25 15.93 -4.2% 1.608 1.620
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.51 9.72 -2.1% 1.658 1.663

@hqucms hqucms changed the title [14_0_X] Backport of 44507 (Add ParticleNet legacy discriminator scores and mass regression to MINIAOD) [14_0_X] Backport of 44507+44726 (Add ParticleNet legacy discriminator scores and mass regression to MINIAOD) Apr 12, 2024
@hqucms
Copy link
Contributor Author

hqucms commented Apr 12, 2024

+1

@mandrenguyen
Copy link
Contributor

+1
Only changes see are to discriminator scores in mini/nana, as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a682e37 into cms-sw:CMSSW_14_0_X Apr 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants