Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParticleNet legacy discriminator scores and mass regression to MINIAOD #44507

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

cmantill
Copy link
Contributor

PR description:

Add back the ParticleNet legacy discriminator scores and mass regression for AK8 Jets. This allows a comparison with newer version of ParticleNet and may be useful in scenarios that fall out of the phase space of the newer ParticleNet training.

  • Changes expected in the miniAOD and nanoAOD output. Added the following branches to nanoAOD:
 FatJet_particleNetLegacy_QCD
 FatJet_particleNetLegacy_Xbb
 FatJet_particleNetLegacy_Xcc 
 FatJet_particleNetLegacy_Xqq 
 FatJet_particleNetLegacy_mass 

PR validation:

MiniAODv4+NanoAODv12 workflow in CMSSW_13_2_X

Backport to CMSSW_13_2_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44507/39623

  • This PR adds an extra 28KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cmantill for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (reconstruction, xpog)

@jfernan2, @vlimant, @cmsbuild, @hqucms, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @demuller, @mbluj, @nhanvtran, @ahinzmann, @jdolen, @Ming-Yan, @gkasieczka, @AlexDeMoor, @Senphy, @mariadalfonso, @mmarionncern, @gpetruc, @azotz, @seemasharmafnal, @andrzejnovak, @AnnikaStein, @schoef, @JyothsnaKomaragiri, @jdamgov, @hatakeyamak, @emilbols, @gouskos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

enable nano

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86ce41/38339/summary.html
COMMIT: 5aa4cbb
CMSSW: CMSSW_14_1_X_2024-03-21-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44507/38339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 45 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2386 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297369
  • DQMHistoTests: Total failures: 1180
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3296169
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16396
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.548 2.548 -0.000 ( -0.0% ) 5.29 5.22 +1.3% 2.143 2.227
2500.001 2.697 2.698 -0.001 ( -0.0% ) 4.76 4.67 +2.0% 2.541 2.249
2500.002 2.637 2.638 -0.001 ( -0.0% ) 4.91 4.83 +1.7% 2.545 2.266
2500.01 1.318 1.318 -0.000 ( -0.0% ) 9.50 9.64 -1.4% 2.253 2.102
2500.011 1.739 1.740 -0.001 ( -0.1% ) 5.23 5.23 -0.0% 2.424 2.136
2500.012 1.580 1.581 -0.000 ( -0.0% ) 7.34 7.44 -1.4% 2.293 2.158
2500.1 2.192 2.192 0.000 ( +0.0% ) 5.24 5.23 +0.3% 2.066 2.051
2500.2 2.308 2.308 0.000 ( +0.0% ) 6.00 6.03 -0.4% 1.977 1.934
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.28 4.29 -0.4% 2.259 1.955
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.67 3.71 -1.1% 2.338 2.055
2500.3 2.064 2.058 0.006 ( +0.3% ) 12.15 12.07 +0.7% 1.958 1.969
2500.301 2.638 2.631 0.007 ( +0.3% ) 10.01 10.08 -0.7% 1.950 1.951
2500.31 1.255 1.254 0.001 ( +0.1% ) 18.98 19.10 -0.6% 2.343 2.365
2500.311 1.642 1.640 0.002 ( +0.1% ) 12.52 13.33 -6.1% 2.437 2.445
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.36 1.45 -6.2% 1.700 1.709
2500.313 1.564 1.564 0.000 ( +0.0% ) 7.04 6.99 +0.7% 1.056 1.062
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.43 14.09 -4.7% 2.055 2.206
2500.315 1.760 1.758 0.002 ( +0.1% ) 13.59 13.92 -2.4% 2.318 1.946
2500.316 3.093 3.091 0.002 ( +0.1% ) 2.19 2.21 -0.8% 2.280 1.990
2500.317 1.789 1.787 0.002 ( +0.1% ) 13.30 13.67 -2.7% 2.160 2.312
2500.4 2.064 2.058 0.006 ( +0.3% ) 12.11 12.30 -1.5% 1.852 1.964
2500.401 1.824 1.824 0.000 ( +0.0% ) 9.77 9.94 -1.7% 1.703 1.690
2500.402 2.638 2.631 0.007 ( +0.3% ) 9.11 9.75 -6.6% 1.949 1.951
2500.403 5.195 5.188 0.007 ( +0.1% ) 1.53 1.55 -1.2% 1.864 1.981
2500.404 2.627 2.620 0.007 ( +0.3% ) 9.48 9.39 +1.0% 1.751 1.786
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.26 1.20 +4.6% 1.367 1.367

@mandrenguyen
Copy link
Contributor

+1

@vlimant
Copy link
Contributor

vlimant commented Mar 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d5b9e0 into cms-sw:master Mar 27, 2024
13 checks passed
@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

It seems a backport to 14_0_X is missing for this. Could you please make one, @cmantill ?

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

It seems a backport to 14_0_X is missing for this. Could you please make one, @cmantill ?

I made the backport here: #44716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants