Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tau sequences to not pull payloads from outside GT (14_0_X) #44715

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Apr 11, 2024

PR description:

This PR addresses a longstanding issue with tau modules pulling payloads from outside GT (#43797).
The issue at the AOD and miniAOD steps is solved since CMSSW 12 series, so this PR fixes it at the nanoAOD step and it is believed that it closes the issue with current CMSSW series (14_X_Y).
Changes introduced by this PR are purely technical and do not change produced samples.

It is verbatim backport of #44685.

PR validation:

Validated locally with nano configurations for Run3 and Run2,run2_nanoAOD_106Xv2 eras with and without access to frontier (the latter with GTs dumped to sqlite files)
Validation with matrix tests in preformed the context of the original PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44685 for 2024 operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

A new Pull Request was created by @mbluj for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • RecoTauTag/Configuration (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)

@hqucms, @cmsbuild, @mandrenguyen, @vlimant, @jfernan2 can you please review it and eventually sign? Thanks.
@AnnikaStein, @missirol, @mbluj, @gpetruc, @azotz this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

please test

@jfernan2
Copy link
Contributor

backport of #44685

@jfernan2
Copy link
Contributor

type tau

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb640b/38789/summary.html
COMMIT: 64d14c2
CMSSW: CMSSW_14_0_X_2024-04-11-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44715/38789/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16456
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 -0.000 ( -0.0% ) 5.20 5.22 -0.3% 2.217 2.219
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.64 4.69 -1.0% 2.230 2.596
2500.002 2.644 2.643 0.000 ( +0.0% ) 4.79 4.87 -1.8% 2.251 2.596
2500.01 1.318 1.318 -0.000 ( -0.0% ) 9.42 9.69 -2.8% 1.981 2.296
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.17 5.24 -1.4% 1.994 2.459
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.29 7.46 -2.4% 2.086 2.374
2500.1 2.197 2.197 0.000 ( +0.0% ) 5.19 5.26 -1.3% 2.050 2.071
2500.2 2.314 2.314 0.000 ( +0.0% ) 5.90 6.01 -1.7% 1.943 1.983
2500.21 1.182 1.182 0.000 ( +0.0% ) 4.23 4.29 -1.3% 1.960 2.270
2500.211 1.546 1.546 0.000 ( +0.0% ) 3.69 3.75 -1.6% 2.056 2.357
2500.3 2.065 2.065 0.000 ( +0.0% ) 11.97 12.47 -3.9% 1.976 1.973
2500.301 2.637 2.637 0.000 ( +0.0% ) 9.63 10.20 -5.6% 1.959 1.957
2500.31 1.255 1.255 0.000 ( +0.0% ) 19.17 19.98 -4.0% 2.365 2.353
2500.311 1.641 1.641 0.000 ( +0.0% ) 13.47 13.36 +0.8% 2.438 2.453
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.42 1.34 +6.2% 1.691 1.698
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.88 6.50 +5.7% 1.050 1.050
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.69 13.95 -1.9% 2.151 2.151
2500.315 1.757 1.757 0.000 ( +0.0% ) 12.55 14.25 -11.9% 1.979 2.331
2500.316 3.093 3.093 0.000 ( +0.0% ) 2.21 2.24 -1.7% 2.093 2.273
2500.317 1.788 1.788 0.000 ( +0.0% ) 12.78 13.75 -7.0% 2.162 2.167
2500.4 2.226 2.226 0.000 ( +0.0% ) 11.59 12.14 -4.6% 1.885 1.883
2500.401 1.749 1.749 0.000 ( +0.0% ) 9.88 10.47 -5.7% 1.813 1.737
2500.402 2.770 2.770 0.000 ( +0.0% ) 9.60 10.16 -5.5% 1.750 1.786
2500.403 5.080 5.080 0.000 ( +0.0% ) 1.58 1.61 -2.2% 1.900 1.938
2500.404 2.778 2.778 0.000 ( +0.0% ) 9.24 9.95 -7.1% 1.855 1.902
2500.5 5.192 5.192 0.000 ( +0.0% ) 15.62 15.98 -2.3% 1.540 1.627
2500.51 9.119 9.119 0.000 ( +0.0% ) 9.73 9.69 +0.4% 1.624 1.660

@hqucms
Copy link
Contributor

hqucms commented Apr 11, 2024

+1

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e8d76bb into cms-sw:CMSSW_14_0_X Apr 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants