Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NANO (and MINI) pulling conditions from outside GT #43797

Closed
vlimant opened this issue Jan 26, 2024 · 22 comments
Closed

NANO (and MINI) pulling conditions from outside GT #43797

vlimant opened this issue Jan 26, 2024 · 22 comments

Comments

@vlimant
Copy link
Contributor

vlimant commented Jan 26, 2024

it was reported in CMS talk that some configuration of nano (in 10.6) is pulling information using "preparation DB" outside of the GT content.
I traced it back to #22840 and cms-nanoAOD#146 , at least, and we need to urgently clean this up.
i.e remove custom connection strings, and include the proper payload in GT

@vlimant
Copy link
Contributor Author

vlimant commented Jan 26, 2024

assign xpog

@cmsbuild
Copy link
Contributor

New categories assigned: xpog

@vlimant,@hqucms you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 26, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @vlimant vlimant.

@antoniovilela, @sextonkennedy, @smuzaffar, @Dr15Jones, @rappoccio, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Jan 26, 2024

type tau

@cmsbuild cmsbuild added the tau label Jan 26, 2024
@vlimant
Copy link
Contributor Author

vlimant commented Jan 26, 2024

I'll continue looking for dependencies, using recently introduced DB tools (#43374)

@saumyaphor4252
Copy link
Contributor

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

@vlimant
Copy link
Contributor Author

vlimant commented Jan 29, 2024

referencing #27393

@mmusich
Copy link
Contributor

mmusich commented Jan 30, 2024

is pulling information using "preparation DB" ...

just to set the record straight, despite the file is called loadRecoTauTagMVAsFromPrepDB_cfi it's not actually pulling anything from the "preparation DB" (connection string frontier://FrontierPrep/CMS_CONDITIONS), but rather from the production database (connection string frontier://FrontierProd/CMS_CONDITIONS), see:

CondDBTauConnection = CondDB.clone( connect = cms.string( 'frontier://FrontierProd/CMS_CONDITIONS' ) )

.. outside of the GT content.

this remains problematic.

@vlimant
Copy link
Contributor Author

vlimant commented Feb 26, 2024

ping @mbluj

@jmhogan
Copy link
Contributor

jmhogan commented Feb 26, 2024

Thanks @vlimant, @mbluj --

In the Open Data context, DPOA's preferred solution is cleaning these IDs from UL/10_6 so that a new release can be used without a new (bigger) GT.

Nano sequences are very likely to be the most used in Open Data, but we do provide instructions on how users can produce their own MC, which follows the full sequence. It would be ideal to clean this out fully. But the Nano sequences have the highest priority. We can test where in the full production chain it fails if needed.

@mbluj
Copy link
Contributor

mbluj commented Feb 27, 2024

@vlimant thank you for pinging, this is not forgotten, but still waits in a queue :(
@jmhogan point is taken, but changes needed in UL/10_6 releases are much more complex than in master as affect RECO, miniAOD, and NANO steps.

@hqucms
Copy link
Contributor

hqucms commented Feb 27, 2024

@jmhogan I think the most practical way ahead is to request a new 106X GT with the missing tags included. A full clean-up of 106X release seems unfeasible at this moment...

@jmhogan
Copy link
Contributor

jmhogan commented Feb 28, 2024

@hqucms We can manage that too -- in that case we would still need a PR with a code change for UL/10_6 that removes the explicit access from the frontier database rather than the GT

@vlimant
Copy link
Contributor Author

vlimant commented Mar 20, 2024

@mbluj : are we good in 14.0 and 14.1 regarding this issue ?

@mbluj
Copy link
Contributor

mbluj commented Mar 20, 2024

@mbluj : are we good in 14.0 and 14.1 regarding this issue ?

Sorry, but not yet.
Is there a GT in sqlite for 14.x to test it w/o frontier? In this releases removal of dependencies on frontier beyond GT should be a small change in configuration (Nano only), so I will give to it high priority to prepare a PR before Easter.

@mbluj
Copy link
Contributor

mbluj commented Mar 20, 2024

Or maybe there is a recipe how to dump a GT from frontier to a sqlite file? And then switch off access to frontier.

@mmusich
Copy link
Contributor

mmusich commented Mar 20, 2024

Or maybe there is a recipe how to dump a GT from frontier to a sqlite file?

e.g.:

conddb copy 106X_dataRun2_v37 --destdb sqlite_file:106X_dataRun2_v37.db --type gt

(notice, it'll take quite some time)

And then switch off access to frontier.

you can customize a cmsDriver command via:

--command='--customise_commands="process.GlobalTag.connect=cms.string(\"sqlite_file:106X_dataRun2_v37.db'\")"'

@mbluj
Copy link
Contributor

mbluj commented Mar 20, 2024

@mmusich thank you. Just to be sure, cmsDriver command given above let CMSSW use conditions from sqlite file, but it does not switch off connection to frontier, right? It has to be done separately - instruction how to do it was given somewhere in this thread, but I cannot find it. Could you quote it here for completeness, please?

@mmusich
Copy link
Contributor

mmusich commented Mar 20, 2024

instruction how to do it was given somewhere in this thread, but I cannot find it. Could you quote it here for completeness, please?

it's in the very first message of the cmsTalk thread:

CondDBTauConnection = CondDB.clone( connect = cms.string( '' ) )

notice that you will have to go through all the additional ESSources (if there are others relevant) to simulate that. That's why it's bad form the maintenance point of view.

@hqucms
Copy link
Contributor

hqucms commented Apr 23, 2024

please close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants