Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 minor improvements to Online DQM Pixel Summary (BP) #44702

Merged

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented Apr 10, 2024

PR description:

Minor improvements in the Online DQM Pixel Summary for 13.6 TeV runs:

  1. Avoid effect of sudden peaks in dead ROC Trend: from last Trend point to average/median of last 5 points
  2. Change deadROC Summary: from dead ROC (Good, but Red) to ‘‘live’’ ROC fraction (Good and Green)
  3. Change Summary map (copy of ‘‘live’’ ROC Summary): from 3 values (0, 0.8 and 1) to full range
  4. Fix ‘‘No DAQ’’ in Online Reports Workspace: fill value of Summary report (now missing)

PR validation:

Data produced with cmsRun, i.e.:

cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024B-v1/RAW runNumber=379031

Results checked in private Online QUI (no change in plot naming/rendering) for two 2024 runs:

Details of SW changes and results in these slides.

About backport

This is a backport to 14_0_X of #44701

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

A new Pull Request was created by @alaperto for CMSSW_14_0_X.

It involves the following packages:

  • DQM/SiPixelPhase1Summary (dqm)

@antoniovagnerini, @syuvivida, @rvenditti, @cmsbuild, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks.
@threus, @fioriNTU, @jandrea, @mmusich, @arossi83, @idebruyn, @sroychow this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@alaperto alaperto marked this pull request as ready for review April 29, 2024 16:06
@tjavaid
Copy link

tjavaid commented Apr 30, 2024

backport of #44701

@tjavaid
Copy link

tjavaid commented Apr 30, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40357c/39182/summary.html
COMMIT: ad966cf
CMSSW: CMSSW_14_0_X_2024-04-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44702/39182/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1
Tested in playback machine with collision run 379315 and since no issues observed

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3692f47 into cms-sw:CMSSW_14_0_X May 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants