Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 minor improvements to Online DQM Pixel Summary #44701

Merged
merged 1 commit into from
May 2, 2024

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented Apr 10, 2024

PR description:

Minor improvements in the Online DQM Pixel Summary for 13.6 TeV runs:

  1. Avoid effect of sudden peaks in dead ROC Trend: from last Trend point to average/median of last 5 points
  2. Change deadROC Summary: from dead ROC (Good, but Red) to ‘‘live’’ ROC fraction (Good and Green)
  3. Change Summary map (copy of ‘‘live’’ ROC Summary): from 3 values (0, 0.8 and 1) to full range
  4. Fix ‘‘No DAQ’’ in Online Reports Workspace: fill value of Summary report (now missing)

PR validation:

Data produced with cmsRun, i.e.:

cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024B-v1/RAW runNumber=379031

Results checked in private Online QUI (no change in plot naming/rendering) for two 2024 runs:

Details of SW changes and results in these slides.

About backport

This PR is intended for 2024 data taking. There will be a backport to 14_0_X in a separate PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44701/39908

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alaperto for master.

It involves the following packages:

  • DQM/SiPixelPhase1Summary (dqm)

@rvenditti, @nothingface0, @antoniovagnerini, @tjavaid, @cmsbuild, @syuvivida can you please review it and eventually sign? Thanks.
@threus, @sroychow, @idebruyn, @jandrea, @arossi83, @mmusich, @fioriNTU this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@alaperto alaperto marked this pull request as ready for review April 29, 2024 16:05
@alaperto alaperto changed the title 4 minor improvements to Online DQM Pixel Summary (WIP) 4 minor improvements to Online DQM Pixel Summary Apr 29, 2024
@alaperto
Copy link
Contributor Author

please test

1 similar comment
@sroychow
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a974b/39181/summary.html
COMMIT: 3d72aec
CMSSW: CMSSW_14_1_X_2024-04-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44701/39181/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29661.402 step 3
29661.403 step 3
29834.402 step 2
29834.403 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@antoniovilela
Copy link
Contributor

@cms-sw/dqm-l2
Please sign the master PR before the backport.

@tjavaid
Copy link

tjavaid commented May 2, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e3b5849 into cms-sw:master May 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants