Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] CepGenInterface: Added missing include #44649

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

forthommel
Copy link
Contributor

PR description:

This PR fixes the build of CepGen release >= 1.2.2 where the include chain was strongly modified. This should cure any build failure expected to be encountered in cms-sw/cmsdist#9124.

PR validation:

Builds
Backport of #44647

FYI: @smuzaffar, @bbilin

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @forthommel for CMSSW_13_0_X.

It involves the following packages:

  • GeneratorInterface/CepGenInterface (generators)

@alberto-sanchez, @mkirsano, @cmsbuild, @menglu21, @GurpreetSinghChahal, @bbilin, @SiewYan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild please test

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild abort

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild please test with cms-sw/cmsdist#9122

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38fa7e/38701/summary.html
COMMIT: ffd0cf5
CMSSW: CMSSW_13_0_X_2024-04-07-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44649/38701/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@cmsbuild please test with cms-sw/cmsdist#9124

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38fa7e/38710/summary.html
COMMIT: ffd0cf5
CMSSW: CMSSW_13_0_X_2024-04-07-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44649/38710/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 241 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9124

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @antoniovilela, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9124, please check if they should be merged together

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7fc8c4d into cms-sw:CMSSW_13_0_X Apr 22, 2024
10 checks passed
@forthommel forthommel deleted the cepgen_patch_13_0_X branch April 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants