Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Update L1TUtmTriggerMenu tag in 2024 MC GTs and for Run3 data RelVals #44598

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Apr 3, 2024

backport of #44594

No technical difference from the master PR but note that the final GT versions are different here since they descope the geometry changes from #44512 in 140X (See #44598 (comment)). The net effect of the master and backport are the same as one can check also in the GT differences listed below in the description.

PR description:

The PR updates the L1TUtmTriggerMenu tag from L1Menu_Collisions2024_v1_0_0_xml to L1Menu_Collisions2024_v1_1_0_xml in the following 2024 MC GTs

  • 140X_mcRun3_2024_design_v8
  • 140X_mcRun3_2024_realistic_v9
  • 140X_mcRun3_2024cosmics_realistic_deco_v9
  • 140X_mcRun3_2024cosmics_design_deco_v7

and the Run3 data Relval GT via modification in autoCondModifiers.py.

More details for the request can be found in the relevant CMS Talk post [1].

[1] https://cms-talk.web.cern.ch/t/update-of-the-2024-l1t-menu-tag-l1menu-collisions2024-v1-1-0/37795/

GT Differences with the last ones are here:

PR validation:

See master PR

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

140X backport of #44594

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

A new Pull Request was created by @saumyaphor4252 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @saumyaphor4252, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@rsreds, @tocheng, @Martin-Grunewald, @yuanchao, @mmusich, @missirol, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

cms-bot internal usage

@saumyaphor4252
Copy link
Contributor Author

test parameters:

  • workflows = 13050.0,13049.0,13046.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0
  • relvals_opt = --what upgrade,standard

@saumyaphor4252
Copy link
Contributor Author

This PR also includes geometry changes from #44512, which will have to be merged first (Full Track Validation ongoing and will be merged soon if all goes smoothly). In the meantime can be used for external PRs needing this for PR tests.

@mmusich
Copy link
Contributor

mmusich commented Apr 8, 2024

@cmsbuild, please test

to start getting it tested - this will soon be needed by TSG for new path integration (see CMSHLT-3122).

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e4c67/38668/summary.html
COMMIT: 6a0143d
CMSSW: CMSSW_14_0_X_2024-04-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44598/38668/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 121 lines to the logs
  • Reco comparison results: 27545 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4917231
  • DQMHistoTests: Total failures: 70398
  • DQMHistoTests: Total nulls: 54
  • DQMHistoTests: Total successes: 4846757
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2486.0159999999983 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12802.0,... ): 111.859 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 12802.0,... ): 75.433 KiB GEM/Digis
  • DQMHistoSizes: changed ( 12802.0,... ): 1.781 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 12802.0,... ): 1.094 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 12802.0,... ): 0.614 KiB GEM/SimHits
  • DQMHistoSizes: changed ( 12802.0,... ): 0.531 KiB GEM/Pad
  • DQMHistoSizes: changed ( 12802.0,... ): 0.432 KiB GEM/PadCluster
  • DQMHistoSizes: changed ( 12802.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 13040.0 ): -2.999 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13046.0 ): -1.470 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13050.0 ): ...
  • Checked 249 log files, 214 edm output root files, 59 DQM output files
  • TriggerResults: found differences in 12 / 57 workflows

@Martin-Grunewald
Copy link
Contributor

type hlt-int
New L1T menu needed for next HLT menu.

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

@cms-sw/alca-l2 please clarify if this PR can make it in time for CMSSW_14_0_5.

@perrotta
Copy link
Contributor

@cms-sw/alca-l2 please clarify if this PR can make it in time for CMSSW_14_0_5.

No, validation is still ongoing.
@rappoccio @antoniovilela please don't wait for this PR to close 14_0_5
I hope this is not putting TSG in troubles, let us know @mmusich in that case and we'll try to cope with it.

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

let us know @mmusich in that case and we'll try to cope with it.

please try to descope the L1T menu changes from the GEM geometry update.

@perrotta
Copy link
Contributor

@mmusich by the way: in the 2024 logs there are quite several errors of this kind:

%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 08-Apr-2024 09:38:29 CEST  Run: 369978 Stream: 0
Algo "L1_ETT1600" not found in the trigger menu L1Menu_Collisions2024_v1_1_0. Could not retrieve algo bit number.
%MSG

It is because the HLT menu has not yet been updated with the new L1T menu, isn't it?

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

It is because the HLT menu has not yet been updated with the new L1T menu, isn't it?

not at all: #43488

@perrotta
Copy link
Contributor

About the issues with the validation of the geometry updates, see also #44512 (comment)

@antoniovilela
Copy link
Contributor

@cms-sw/alca-l2 please clarify if this PR can make it in time for CMSSW_14_0_5.

No, validation is still ongoing. @rappoccio @antoniovilela please don't wait for this PR to close 14_0_5 I hope this is not putting TSG in troubles, let us know @mmusich in that case and we'll try to cope with it.

We will descope it from 14_0_5, but we can include it for a patch release (together with #44694).

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2024

We will descope it from 14_0_5, but we can include it for a patch release (together with #44694).

we're going to need a version of this with the pure L1T menu update for HLT integration purposes. If AlCa cannot deliver that in time, I guess we'll make a PR with GT candidates and then those could be converted later on to full fledged Global Tags from AlCa at their own pace.

@saumyaphor4252
Copy link
Contributor Author

saumyaphor4252 commented Apr 10, 2024

I'll update the PR segregating the geometry tag updates in the next hour.

@saumyaphor4252 saumyaphor4252 force-pushed the alca-140X_Update_L1UtmTriggerMenu_tag branch from 6a0143d to f634840 Compare April 10, 2024 19:36
@cmsbuild
Copy link
Contributor

Pull request #44598 was updated. @saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please check and sign again.

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e4c67/38755/summary.html
COMMIT: f634840
CMSSW: CMSSW_14_0_X_2024-04-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44598/38755/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 38 lines to the logs
  • Reco comparison results: 94 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4925307
  • DQMHistoTests: Total failures: 438
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4924847
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.2800000000000007 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • Checked 249 log files, 214 edm output root files, 59 DQM output files
  • TriggerResults: found differences in 3 / 57 workflows

@mmusich
Copy link
Contributor

mmusich commented Apr 11, 2024

  • DQMHistoSizes: changed ( 12834.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • TriggerResults: found differences in 3 / 57 workflows

changes look as expected from the master PR:

@perrotta
Copy link
Contributor

+alca

  • This PR has the very same GT updates included in the master PR Update L1TUtmTriggerMenu tag in 2024 MC GTs and for Run3 data RelVals #44594
  • As pointed out in the PR description, the difference in the GT versions are due to the revert in the GT of the RPC/GEM geometry and alignment updates, which are however independent from the net content of this PR, that can therefore be considered an exact backport

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 63d0c3c into cms-sw:CMSSW_14_0_X Apr 11, 2024
11 checks passed
@saumyaphor4252 saumyaphor4252 deleted the alca-140X_Update_L1UtmTriggerMenu_tag branch November 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants