-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44512
[14.0.X] Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44512
Conversation
A new Pull Request was created by @saumyaphor4252 for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @perrotta, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1870ea/38344/summary.html
Comparison SummarySummary:
|
The reason for holding this PR in 140X is some degradation and changes observed in muon reconstruction from the GT update in the ongoing Full Track Validation in https://its.cern.ch/jira/browse/CMSALCA-260, which are not fully understood and expected. See for eg: Also FYI @bsunanda @cms-sw/muon-dpg-l2 @cms-sw/muon-pog-l2 (maybe also @cms-sw/upgrade-l2 ) We are going to do one last check with another run, but otherwise we will be considering to revert the changes until this is understood. Also @cms-sw/muon-dpg-l2 @cms-sw/muon-pog-l2 it would be great if you could provide some feedback on how critical these changes would be by taking a look at the validation plots in https://its.cern.ch/jira/browse/CMSALCA-260. |
2b8d06f
to
0af60d9
Compare
Pull request #44512 was updated. @saumyaphor4252, @cmsbuild, @perrotta, @consuegs can you please check and sign again. |
Pull request #44512 was updated. @consuegs, @saumyaphor4252, @cmsbuild, @perrotta can you please check and sign again. |
@cmsbuild please test Following on #44512 (comment): more details can be found in https://its.cern.ch/jira/browse/CMSALCA-260 but to summarize:
|
-1 Failed Tests: RelVals RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here:
RelVals
Expand to see more relval errors ...
RelVals-INPUT |
please test
|
not related to das queries, but rather to the fact that the last test dragged in #44660 without the corresponding |
backport of #44594 Please notice that the following GTs are identical:
Therefore, this PR is backporting exactly what is currently in the master of cmssw, which was merged with #44594 |
Thank you @mmusich for the clarification. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1870ea/39017/summary.html
Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
Hi Andrea, sorry if this was discussed yesterday and I missed. Is this PR meant for 14_0_6? |
Hi Antonio. |
Thanks. |
+1 |
backport of #44497
Note that the GT versions here are different than the ones in master PR because descoping was done for #44598 (comment) which increased the version numbers of the GTs for this backport. But the net effect of the master and backport PR is the same, with just the geometry update.
PR description:
The PR updates the 2024 geometry and compatible GEM alignment conditions tags in the relevant MC GTs:
140X_mcRun3_2024_design_v9
140X_mcRun3_2024_realistic_v10
140X_mcRun3_2024cosmics_realistic_deco_v10
140X_mcRun3_2024cosmics_design_deco_v8
More details with the full list of tag updates and links to relevant presentations can be found in the CMS Talk request in [1].
[1] https://cms-talk.web.cern.ch/t/gt-mc-data-update-of-2024-gem-and-rpc-geomtery-conditions-for-data-and-mc/36739
GT Differences with the last ones are here:
Phase1 2024 design:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024_design_v8/140X_mcRun3_2024_design_v9
Phase1 2024 realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024_realistic_v9/140X_mcRun3_2024_realistic_v10
Phase1 2024 cosmics realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024cosmics_realistic_deco_v9/140X_mcRun3_2024cosmics_realistic_deco_v10
Phase1 2024 cosmics design:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024cosmics_design_deco_v7/140X_mcRun3_2024cosmics_design_deco_v8
PR validation:
See master PR #44497
See also the Full Track validation in https://its.cern.ch/jira/browse/CMSALCA-260
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #44497