Backport spin lock bug fixes

[wddgit]

PR description:

Backports bug fixes to a couple of spin locks to 14_0_X. This backports PRs #44447 and #44517. See Issue #44413 for related discussion.

These bugs were causing rare seg faults in IB tests. We believe they mostly only occurred when concurrent lumis were configured and multiple lumis were actually being executed. The failure actually observed seemed more common when lumis containing no events were being processed because it requires global end lumi transitions running at the same time. Even in those circumstances the failures are rare.

PR validation:

Relies on existing tests.

[cmsbuild]

A new Pull Request was created by @wddgit for CMSSW_14_0_X.

It involves the following packages:

• DPGAnalysis/Skims (pdmv)
• FWCore/Framework (core)

@smuzaffar, @Dr15Jones, @makortel, @miquork, @AdrianoDee, @sunilUIET, @cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @youyingli, @AnnikaStein, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[wddgit]

please test

[makortel]

type bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80c13a/38529/summary.html
COMMIT: 8ed0a21
CMSSW: CMSSW_14_0_X_2024-04-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44584/38529/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 81 lines from the logs
• Reco comparison results: 59 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346148
• DQMHistoTests: Total failures: 1352
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344774
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

Comparisons show the usual

• spurious differences in outputs of Run-3 wfs *.7 #39803
• Non reproducibility in wf 136.793 #43293
• Non-reproducibility in TriggerResults in 24834.0, 24834.911, and 25034.999 #43790

[makortel]

+core

[makortel]

@cms-sw/pdmv-l2 Could you review and sign this backport?

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1