-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Puppi] Backport of #44050 (Hadronic tau recovery with protection for fromPV==2 charged particles) to 14_0_X #44566
Conversation
A new Pull Request was created by @nurfikri89 for CMSSW_14_0_X. It involves the following packages:
@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c3c5e/38515/summary.html Comparison SummarySummary:
|
type tau, jetmet |
hold
|
Pull request has been put on hold by @antoniovilela |
If I am not mistaken, this PR is part of the efforts from JME, BTV and TAU to have a unified tagger that uses PUPPI jets as input. @nurfikri89 , can you please confirm? |
Yes. This is my understanding from what @abencke and the PUPPI team want to achieved. We hope that with this PR, the PUPPI tune for 2024 datasets and MCs will be in sync with the planned full re-reco 2022 and & 2023. |
unhold |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged. |
precisely |
Backport of #44050
Original PR description:
(Making this PR on behalf of @abenecke)
It was spotted by the ParticleNet team that the efficiency to identify hadronic tau candidates for PUPPI jets at low pT is significantly lower than for CHS jets (https://indico.cern.ch/event/1300663/#2-particlenet-ak4-ak8-tagger-r). The main reason for this is that PUPPI treats particles with fromPV1&2 different than CHS. It was found that PUPPI rejects one prong hadronic taus that most of the time has
fromPV==2
andpT < 20 GeV
(pT > 20 GeV
are protected by PUPPI already). This PR is supposed to recover the loss of hadronic tau candidates by keeping charged particles withpT > 4 GeV
andfromPV==2
while maintaining the jet energy resolution, eff and purity for jets. A comparison of different options was done in this presentation: https://indico.cern.ch/event/1364503/#5-puppi-tau-tunePR validation:
passes the usual runTheMatrix test:
runTheMatrix.py -l limited -i all --ibeos