[Puppi] Hadronic tau recovery with protection for fromPV==2 charged particles

[nurfikri89]

PR description:

(Making this PR on behalf of @abenecke)

It was spotted by the ParticleNet team that the efficiency to identify hadronic tau candidates for PUPPI jets at low pT is significantly lower than for CHS jets (https://indico.cern.ch/event/1300663/#2-particlenet-ak4-ak8-tagger-r). The main reason for this is that PUPPI treats particles with fromPV1&2 different than CHS. It was found that PUPPI rejects one prong hadronic taus that most of the time has fromPV==2 and pT < 20 GeV (pT > 20 GeV are protected by PUPPI already). This PR is supposed to recover the loss of hadronic tau candidates by keeping charged particles with pT > 4 GeV and fromPV==2 while maintaining the jet energy resolution, eff and purity for jets. A comparison of different options was done in this presentation: https://indico.cern.ch/event/1364503/#5-puppi-tau-tune

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38988

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38988/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38988/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44050/38990

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

• CommonTools/PileupAlgos (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @hatakeyamak, @missirol, @ahinzmann, @gkasieczka, @jdolen this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[hqucms]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9c0ec/37637/summary.html
COMMIT: dd92bc9
CMSSW: CMSSW_14_1_X_2024-02-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44050/37637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 4114 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 6959
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3238384
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[vlimant]

assign xpog

[cmsbuild]

New categories assigned: xpog

@vlimant,@hqucms you have been requested to review this Pull request/Issue and eventually sign? Thanks

[mandrenguyen]

Based on the PR description, I understand why changes are observed for Puppi jets, but were you expecting changes to the vanilla slimmedJets (presumably CHS?), e.g:
here

[nurfikri89]

@mandrenguyen the plot says its slimmedJetsAK8 so its the AK8 Puppi jets, which we expect some changes.

[hqucms]

@nurfikri89 Has it been checked what are impacts of this change on the existing AK4 and AK8 jet taggers?

[nurfikri89]

@hqucms this is in the process by @abenecke

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

please test

• need to refresh tests.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9c0ec/38469/summary.html
COMMIT: dd92bc9
CMSSW: CMSSW_14_1_X_2024-03-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44050/38469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 3944 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297857
• DQMHistoTests: Total failures: 5488
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3292349
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[antoniovilela]

@nurfikri89 Has it been checked what are impacts of this change on the existing AK4 and AK8 jet taggers?

@nurfikri89
You mentioned this was being checked. Could you summarize the conclusions?
Thanks.

[rappoccio]

+reconstruction Only puppi jets are affected, although I found a bit confusing that slimmedJetsAK8 is done with PUPPI, but slimmedJets (i.e., R=0.4) are not. I wonder if we shouldn't always just state the UE subtraction algo for clarity, e.g., slimmedJetsCHS. At least if we're planning to continue to support two algos.

This was a historical accident.

[rappoccio]

Apologies, I accidentally clicked the wrong button.

[rappoccio]

+1

[mandrenguyen]

type tau, jetmet