Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpack displaced pT from OMTF at the uGMT inputs #44543

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Unpack displaced pT from OMTF at the uGMT inputs #44543

merged 1 commit into from
Apr 2, 2024

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Mar 26, 2024

PR description:

uGMT now uses the unconstrained pT from OMTF, so we need to unpack it. I've added the functionality to pack and unpack it in this PR.

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Mar 26, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2024 •
edited
Loading

cms-bot internal usage

@dinyar dinyar mentioned this pull request Mar 26, 2024
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44543/39686

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinyar for master.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/L1TMuon (l1)
  • L1Trigger/L1TNtuples (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@kreczko, @Martin-Grunewald, @missirol, @thomreis, @JanFSchulte, @eyigitba this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d2d9/38522/summary.html
COMMIT: b54c5f7
CMSSW: CMSSW_14_1_X_2024-03-31-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44543/38522/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

missirol
missirol reviewed Mar 31, 2024
View reviewed changes
EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTSetup.cc Outdated
@@ -103,6 +106,9 @@ namespace l1t {
// input muons on links 36-71
auto gmt_in_unp = static_pointer_cast<l1t::stage2::RegionalMuonGMTUnpacker>(
UnpackerFactory::get()->make("stage2::RegionalMuonGMTUnpacker"));
if (fw >= 0x8010000) {
gmt_in_unp->setUseEmtfDisplacementInfo();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: why is this Emtf and not Omtf ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @missirol,

you're absolutely right, this is a bug. Apologies. Will commit the fix either today or tomorrow.

Cheers,
Dinyar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed a fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@dinyar dinyar force-pushed the unpack_displaced_pt_from_omtf branch from b54c5f7 to 7b2ef4d Compare March 31, 2024 15:00
@dinyar dinyar force-pushed the unpack_displaced_pt_from_omtf branch from 7b2ef4d to 979af89 Compare March 31, 2024 15:00
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44543/39746

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44543 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

@aloeliger
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d2d9/38524/summary.html
COMMIT: 979af89
CMSSW: CMSSW_14_1_X_2024-03-31-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44543/38524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

  • @dinyar We'll sign the backport too, I think it's okay by ORP, but they would potentially like to package it with: [14_0_X] Update unpacker for L1T Calo scouting + DataFormat tests #44394 for next week, which I am just now being made aware of. They want an L1 opinion on the unpacker, and the L1T opinion on scouting and unpackers, especially together, is unofficially whatever your opinion is. If you could take a look at that it would help us out.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a29738c into cms-sw:master Apr 2, 2024
11 checks passed
This was referenced Apr 4, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missirol missirol missirol left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
6 participants
@dinyar @cmsbuild @epalencia @aloeliger @antoniovilela @missirol