Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Update unpacker for L1T Calo scouting + DataFormat tests #44394

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

Mmiglio
Copy link
Contributor

@Mmiglio Mmiglio commented Mar 13, 2024

Backport of #44393 and Data Format tests of #43984

PR description:

This PR updates the unpacker for L1T Calo scouting, following the upgrade of HW/SW upgrade of the scouting DAQ system.
Backported also data format tests for files produced with previous releases.

PR validation:

The PR has been validated using data collected with the scouting system in the past week(s) and comparing results with L1T objects collected during CRAFT with the cdaq.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #44393 and #43984 to CMSSW_14_0_X for data tacking.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Mmiglio for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/L1Scouting (daq)
  • DataFormats/L1ScoutingRawData (daq)
  • EventFilter/L1ScoutingRawToDigi (daq)
  • L1TriggerScouting/Utilities (daq)

@cmsbuild, @smorovic, @emeschi can you please review it and eventually sign? Thanks.
@rovere, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #44394 was updated. @smorovic, @cmsbuild, @emeschi can you please check and sign again.

@smorovic
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f749/38129/summary.html
COMMIT: f6b631a
CMSSW: CMSSW_14_0_X_2024-03-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44394/38129/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestL1ScoutingFormat had ERRORS

Comparison Summary

Summary:

@rappoccio
Copy link
Contributor

hold

  • We need a justification as to why this new feature is being backported to the stable branch. Only bug fixes should be backported.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 14, 2024
@Mmiglio
Copy link
Contributor Author

Mmiglio commented Mar 14, 2024

Hi @rappoccio,
We need this backport as the L1Scouting system hardware is changed, hence a slightly different unpacker is needed.
Moreover, as far as I understood, we need to be using the same CMSSW version as the HLT because of plans for common repacking.
On the other hand, touching the DataFormat tests is not really needed. I just thought it was a good Idea to align the changes, but of course I can restore the original version.

@cmsbuild
Copy link
Contributor

Pull request #44394 was updated. @emeschi, @smorovic, @cmsbuild can you please check and sign again.

@Mmiglio
Copy link
Contributor Author

Mmiglio commented Mar 18, 2024

Hi, I removed the unnecessary changes on the data format size. I kept only:

  • A fix for OrbitCollection as the method getBxSize needs to return an unsigned
  • Named tcp source IDs for the 2024 calo data source

Please let me know if there is anything more that can be done from side.

@smorovic
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f749/38223/summary.html
COMMIT: 26de14a
CMSSW: CMSSW_14_0_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44394/38223/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smorovic
Copy link
Contributor

+daq

@aloeliger
Copy link
Contributor

@dinyar, FYI. We were asked about this release and about any potential pitfalls. Were you aware of this change?

@dinyar
Copy link
Contributor

dinyar commented Apr 2, 2024

Hi @aloeliger,

thanks for tagging me! Yes, this is the unpacker we'd like to use for data taking this year (along with some fixes). We're currently using a private version of CMSSW with these changes for our tests at P5, but we strongly prefer to use an actual release.

Cheers,
Dinyar

@antoniovilela
Copy link
Contributor

unhold

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c1f48bd into cms-sw:CMSSW_14_0_X Apr 2, 2024
10 checks passed
@Mmiglio Mmiglio deleted the 140X_caloTcpUnpacker branch June 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants