Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard file names in DQM/HcalTasks config files [14_0] #44480

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Added cfi or cff extensions.

PR validation:

Code compiles.

backport of #44408 on request of DQM l2s.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

A new Pull Request was created by @Dr15Jones for CMSSW_14_0_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)

@rvenditti, @antoniovagnerini, @tjavaid, @syuvivida, @nothingface0 can you please review it and eventually sign? Thanks.
@batinkov, @DryRun, @threus, @francescobrivio, @bsunanda, @abdoulline this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@Dr15Jones Dr15Jones changed the title Use standard file names in DQM/HcalTasks config files Use standard file names in DQM/HcalTasks config files [14_0] Mar 20, 2024
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58e8ad/38274/summary.html
COMMIT: 605537f
CMSSW: CMSSW_14_0_X_2024-03-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44480/38274/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346212
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346187
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Mar 20, 2024

backport of #44408

@tjavaid
Copy link

tjavaid commented Mar 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 03146c9 into cms-sw:CMSSW_14_0_X Mar 21, 2024
10 checks passed
@Dr15Jones Dr15Jones deleted the fixNamesDQMHcalTasks_14_0 branch March 26, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants