-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard file names in DQM/HcalTasks config files #44408
Conversation
Added cfi or cff extensions.
@makortel FYI |
cms-bot internal usage |
NOTE: to fully comply to our standard file naming conventions, these files should start will lower case letters to correspond to the module labels for the modules the files are defining. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44408/39481
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@tjavaid, @antoniovagnerini, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c41c90/38144/summary.html Comparison SummaryThe workflows 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
@Dr15Jones , could you please create another PR viz. its backport for |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Added cfi or cff extensions. This avoids name collision with auto generated files from fillDescriptions.
PR validation:
I used
git grep --cached
to look for all references in CMSSW to the files and modified them all.