Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard file names in DQM/HcalTasks config files #44408

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Mar 14, 2024

PR description:

Added cfi or cff extensions. This avoids name collision with auto generated files from fillDescriptions.

PR validation:

I used git grep --cached to look for all references in CMSSW to the files and modified them all.

@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

NOTE: to fully comply to our standard file naming conventions, these files should start will lower case letters to correspond to the module labels for the modules the files are defining.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44408/39481

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)

@tjavaid, @antoniovagnerini, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks.
@DryRun, @threus, @abdoulline, @batinkov, @francescobrivio, @bsunanda this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c41c90/38144/summary.html
COMMIT: 22c387f
CMSSW: CMSSW_14_1_X_2024-03-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44408/38144/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

@tjavaid
Copy link

tjavaid commented Mar 19, 2024

@Dr15Jones , could you please create another PR viz. its backport for 14_0_X ? Thanks!

@tjavaid
Copy link

tjavaid commented Mar 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a2ae75c into cms-sw:master Mar 20, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the fixNamesDQMHcalTasks branch March 26, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants