-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_0_X] KalmanFilter fix for Phase 2 L1 tracking #44457
Conversation
A new Pull Request was created by @aehart for CMSSW_14_0_X. It involves the following packages:
@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
Backport of #44427 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d53062/38388/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
type bug-fix |
+1 |
PR description:
This PR resolves the failure reported in #44306. The problem was that
matRinv
is defined as a 2×2 matrix:https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0/L1Trigger/TrackFindingTMTT/src/KFbase.cc#L549
while
unitMatrix
is defined as a 5×5 matrix (nHelixPar_
is five when running the extended tracking):https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0/L1Trigger/TrackFindingTMTT/src/KFbase.cc#L554
So then there is an exception caused by assigning one to the other on this line:
https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0/L1Trigger/TrackFindingTMTT/src/KFbase.cc#L556
Hence the error message:
PR validation:
A recipe for reproducing the exception can be found in #44306. The changes in this PR allow the recipe to run without any exception.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Original PR: #44427