Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 13.0.X] Update Pythia Hook for BB4L #44421

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

lauridsj
Copy link
Contributor

PR description:

This PR backports #44061 , an update to the Pythia Hook for the BB4L matrix element generator that is needed for the new version of BB4L.

PR validation:

Original PR was tested to produce the same output as the previous version on the old bb4l version, and to produce the same output as a standalone implementation received from the authors (see original PR).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44061 to CMSSW 13_0_X, needed for Run 3 2023 MC production.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lauridsj for CMSSW_13_0_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@bbilin, @GurpreetSinghChahal, @cmsbuild, @SiewYan, @menglu21, @alberto-sanchez, @mkirsano can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2024

cms-bot internal usage

@menglu21
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc3ab9/38217/summary.html
COMMIT: d1dea98
CMSSW: CMSSW_13_0_X_2024-03-17-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44421/38217/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

hold

  • This looks like a major change so will need to be discussed at the ORP meeting and signed off by PPD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2024

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@menglu21
Copy link
Contributor

menglu21 commented Apr 2, 2024

@jordan-martins @malbouis could you please have a look

@menglu21
Copy link
Contributor

menglu21 commented Apr 9, 2024

@jordan-martins @malbouis thanks for merging the10_6_X one, could you please also signoff this pr

@jordan-martins
Copy link
Contributor

Hi @cms-sw/orp-l2, we @cms-sw/ppd-l2 sign this off.
Best,
PPD

@antoniovilela
Copy link
Contributor

unhold

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 77e6d7c into cms-sw:CMSSW_13_0_X Apr 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants