Update Pythia Hook for BB4L #44061
Update Pythia Hook for BB4L #44061
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44061/39005
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44061/39006
|
|
A new Pull Request was created by @lauridsj for master. It involves the following packages:
@menglu21, @bbilin, @cmsbuild, @mkirsano, @SiewYan, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
Hey @menglu21 , it looks like the tests are somehow stuck... do you know what is going on? |
|
not sure what happened, @rappoccio, @sextonkennedy, @antoniovilela could you please have a look |
|
abort |
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44061/39440
|
|
Pull request #44061 was updated. @mkirsano, @GurpreetSinghChahal, @SiewYan, @cmsbuild, @alberto-sanchez, @bbilin, @menglu21 can you please check and sign again. |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc8b5d/38078/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR replaces the Pythia Hook used for showering events produced with the bb4l generator with a new version provided by the authors.
There are two reasons why this is necessary, both related to the new bb4l version that was released last year:
I have copied the version provided by the authors with as few changes as necessary to adapt it to CMSSW and Pythia 8.2 (the original version was for Pythia 8.3).
Note that some of the flags present in the old hook are no longer present. These flags were meant as cross-checks by the bb4l authors to test the effects of several assumptions of the matching, and were never used in CMS for official MC production. Thus I did not bother to reimplement them in the new version of the hook. (Also note that the most important such flag for an "alternate" matching,
POWHEG:bb4l:ScaleResonance:veto, is still there.)In addition, I have added a new flag that was not present in the version of the authors:
POWHEG:bb4l:vetoAllRadtypes. This flag is not meant for bb4l (and should be left at its default value of false when showering bb4l), but instead for the ttb_NLO_dec generator, which we might want to generate in the future as well. This generator also generates up to one real emission per decaying top, thus has the same final state as bb4l and can use the same hook. However, after checking with the authors, we were notified that it is necessary to modify the hook to also veto Powheg remnant events (radtype2), which is not the case for bb4l. This alternate behavior is implemented with this flag.PR validation:
I have confirmed that, when run on LHE files produced by the old bb4l, the new and old versions of the hook give exactly the same output.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
The PR will need to be backported to all MC production releases, i.e.
10_6_X (UL)
12_4_X (2022)
13_0_X (2023 I think?)
(Any that I missed?)