Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] EL9-migration related patches to All-in-one #44377

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 12, 2024

backport of #44364

PR description:

This PR mostly concerns patches for TkAl all-in-one validation tool needed after the lxplus migration to EL9. Among those the most relevant are:

  • changes to the HTCondor submission file
  • fixes on ROOT-related issues (that escaped our unit tests) for the GCP tool
  • The rest of the changes is plot style-related.

PR validation:

All unit tests passed for el8_amd64_gcc12 (CMSSW_14_1_X_2024-03-09-1100). Code checks ok. Code format done.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44364 for the data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@perrotta, @saumyaphor4252, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@tocheng, @yuanchao, @tlampen, @mmusich, @rsreds, @adewit this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7555b2/38060/summary.html
COMMIT: d2bb401
CMSSW: CMSSW_14_0_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44377/38060/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2024

Spurious failures, let's retry

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7555b2/38074/summary.html
COMMIT: d2bb401
CMSSW: CMSSW_14_0_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44377/38074/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3342271
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342246
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Mar 13, 2024

@cms-sw/alca-l2 can this PR be signed? The master PR #44364 was included in CMSSW_14_1_X_2024-03-12-2300 and there haven't been failures related to this.

@perrotta
Copy link
Contributor

+1

  • IB tests in master did not complete yet, but they are all succesfull up to now.
  • And the relevant unit tests already succeed
    -Therefore, it can be signed, and merged as soon as the release managers will be able to pick it up

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 19f4a22 into cms-sw:CMSSW_14_0_X Mar 13, 2024
10 checks passed
@mmusich mmusich deleted the mm_fromkello-EL9patches branch March 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants