-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EL9-migration related patches to All-in-one #44364
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44364/39412
|
A new Pull Request was created by @TomasKello for master. It involves the following packages:
@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
Alignment/OfflineValidation/python/TkAlAllInOneTool/templates/condorTemplate.submit
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44364/39415
|
Pull request #44364 was updated. @saumyaphor4252, @consuegs, @perrotta, @cmsbuild can you please check and sign again. |
@cmsbuild, please test |
6e4322f
to
7b07001
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44364/39422
|
Pull request #44364 was updated. @cmsbuild, @perrotta, @saumyaphor4252, @consuegs can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc1338/38049/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@TomasKello will you open a 14.0.X backport? |
to speed-up integration I opened #44377 (so we can flag it today at the ORP) |
+1 |
This PR mostly concerns patches for TkAl all-in-one validation tool needed after the lxplus migration to EL9. Among those the most relevant are:
The rest of the changes is plot style-related.
All unit tests passed for el8_amd64_gcc12 (CMSSW_14_1_X_2024-03-09-1100). Code checks ok. Code format done.
Will require backport to CMSSW_14_0_X in order to perform validation of CRAFT.