Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL9-migration related patches to All-in-one #44364

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

TomasKello
Copy link
Contributor

This PR mostly concerns patches for TkAl all-in-one validation tool needed after the lxplus migration to EL9. Among those the most relevant are:

  • changes to the HTCondor submission file
  • fixes on ROOT-related issues (that escaped our unit tests) for the GCP tool
    The rest of the changes is plot style-related.

All unit tests passed for el8_amd64_gcc12 (CMSSW_14_1_X_2024-03-09-1100). Code checks ok. Code format done.

Will require backport to CMSSW_14_0_X in order to perform validation of CRAFT.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44364/39412

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TomasKello for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@tlampen, @rsreds, @tocheng, @yuanchao, @adewit, @mmusich this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44364/39415

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44364 was updated. @saumyaphor4252, @consuegs, @perrotta, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44364/39422

@cmsbuild
Copy link
Contributor

Pull request #44364 was updated. @cmsbuild, @perrotta, @saumyaphor4252, @consuegs can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc1338/38049/summary.html
COMMIT: 7b07001
CMSSW: CMSSW_14_1_X_2024-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44364/38049/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Mar 12, 2024

@TomasKello will you open a 14.0.X backport?

@mmusich
Copy link
Contributor

mmusich commented Mar 12, 2024

will you open a 14.0.X backport?

to speed-up integration I opened #44377 (so we can flag it today at the ORP)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d389c1c into cms-sw:master Mar 12, 2024
11 checks passed
@TomasKello TomasKello deleted the kello-EL9patches branch October 3, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants