Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag for the SiPixelLorentzAngleSimRcd in the Phase2 MC GT #44356

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Mar 8, 2024

PR description:

Fix the phase2_realistic GT: in a previous update of that GT (ported to autoCond with #43763) a mistake slipped in because a wrong tag was taken for SiPixelLorentzAngleSimRcd. This is corrected in the GT140X_mcRun4_realistic_v3

Relevant github issue describing the need to move the default phase2 geometry to D98 is still #42945

Modified tag:

  • SiPixelLorentzAngleSimRcd from SiPixelLorentzAngle_phase2_T25_v0_mc to SiPixelSimLorentzAngle_phase2_T25_v0_mc

Difference with respect to the previous run4 MC GT:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It will be backported to CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

cms-bot internal usage

@perrotta perrotta changed the title Fix tag for the SiPixelLorentzAngleSimRcd Fix tag for the SiPixelLorentzAngleSimRcd in the Phase2 MC GT Mar 8, 2024
@perrotta
Copy link
Contributor Author

perrotta commented Mar 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44356/39395

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @saumyaphor4252, @consuegs can you please review it and eventually sign? Thanks.
@fabiocos, @yuanchao, @tocheng, @rsreds, @missirol, @Martin-Grunewald, @mmusich this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adab04/37994/summary.html
COMMIT: 5f831e1
CMSSW: CMSSW_14_1_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44356/37994/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor Author

perrotta commented Mar 9, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 92eedea into cms-sw:master Mar 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants