-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning obsolete GeometryExtended2026D* from all config files; Use Default config #42945
Comments
A new Issue was created by @srimanob Phat Srimanobhas. @rappoccio, @smuzaffar, @sextonkennedy, @makortel, @antoniovilela, @Dr15Jones can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign upgrade |
New categories assigned: upgrade @AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks |
This is a recurrent issue.
which contain just the |
@mmusich @cms-sw/alca-l2 Thx. |
normally yes, but it's not strictly enforced (at least to my knowledge). |
Thanks @mmusich Question to @cms-sw/alca-l2 |
@srimanob the GT in autocond is supposed to point to the default geometry. If not, it should be notified and then updated. Yes, this is a manual procedure: please let AlCa know in case any update is needed for it. |
@perrotta, if that's the case, this situation is currently not verified for the master branch in which the default geometry is D98 (which should use
), while the autoCond key seems still to point to a T21 geometry:
please cross-check. |
Thank you @mmusich. Therefore, if I understand correctly, the default geometry should be the one that corresponds to the T25 customization in Configuration/AlCa/python/autoCondPhase2.py, which is different from what currently in the DB (T21, as far as I can see). The tracker config which corresponds to D98 should be T32 rather than T25. However, I imagine that they are similar enough that do not require separated tracker configurations (see Configuration/Geometry/README.md): correct? In any case Configuration/AlCa/python/autoCondPhase2.py only customizes the Tracker geometry: is it enough to migrate just them , or should we also customize other subsystems in the GT, instead, to fully migrate to D98? And, finally: @srimanob are you requesting to update the affected tags in the Phase2 default GT in order to synchronize it with the current default D98 update geometry? Or that "default" is expected to change often, so that the customizations are more practical, instead? In any case, this could be implemented when we'll derive the 140X GTs for Phase2. |
it is not only similar enough, it is identical, see cmssw/Configuration/Geometry/README.md Line 77 in f5cbbf1
this is NOT the case, it customizes all the conditions that depend on the geometry.
as far as I am aware the Tracker is the only subsystem that supports different geometries (with geometry-dependent conditions) in the same release. |
Hi @perrotta The default may change 2-3 times a year (~HGCal, Tracker, MTD at least once a year). I try to keep running the most recent geometry. As @mmusich states, only tracker that needs customization. So, maybe 1 (or 2) times a year that we update the tracker baseline, we will need your help to update the GT. Regarding to move Phase-2 GT to T25, do you need something from Phase-2 tracker (or me), or any short talk at Alca meeting before the GT will be built. Thanks. |
It would be appropriate, indeed, in particular to decide the update strategies: thank you for proposing it, Phat. |
Technically that's nothing terribly new (see here for some details). EDIT : incidentally I think the tracker geometry for phase2 in converging (after some technical difficulties are overcome) to a final layout sometime this year, so this extra requirement would be fairly soon dropped. |
Thank you for the link. It is indeed almost five years old (I see that "2023" was the reference year for Phase2 in it...) and it is probably worth to quickly refresh the audience at the AlCa meeting.
This is indeed the main point: to decide when to manually update the "physical" GT key and the autoCond link: new campaigns, new releases, when the Upgrade contact tells AlCa that a new default geometry was agreed...
Great, some less manual work to adapt to it in sight, then! |
Hi @perrotta I will be available on Monday for short update on phase 2 geometry and workflow. Thx. |
Thank you Phat, added to the agenda: https://indico.cern.ch/event/1358549 |
for those who didn't attend (since there are no minutes posted), would it be possible to summarize here the action items on this topic? |
|
A new GT, 140X_mcRun4_realistic_v1, with the "default" T25 Phase2 tracker geometry was created You can see the tag difference with respect to previous 133X_mcRun4_realistic_v1 in: The new GT will be included in autocond in 140X as default GT for Phase2 |
Here's the PR to include the above GT in autoCond: #43763 |
Thanks @cms-sw/alca-l2 |
D49 geometry is obsolete for long time, however there are still numbers of config files which keep it
https://github.com/search?q=repo%3Acms-sw%2Fcmssw+GeometryExtended2026D49&type=code&p=1
I assume none of them are used.
This ticket is to keep track of cleaning the config files on Phase-2.
The text was updated successfully, but these errors were encountered: