Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of FOG special HLT menus [140X] #44313

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Mar 5, 2024

PR description:

Handling of FOG special HLT menus [140X]

https://its.cern.ch/jira/browse/CMSHLT-3092 : Completion of the offline "Special" table and lists of paths for individual special menus

See also discussion here:
https://docs.google.com/document/d/1XxsH3qXt7ZO4LIuwQg-I-Lp5rekkWsxSEG_Mwv1nh0Q/edit#heading=h.p0nxi1qdtn0t

PR validation:

Executing scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44311 to 2024 data taking release

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

A new Pull Request was created by @Martin-Grunewald for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@argiro, @thomreis, @ReyerBand, @rchatter, @missirol, @silviodonato, @wang0jin this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

Pull request #44313 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich mmusich force-pushed the SpecialMenus_140X branch from 55523da to 0871ebd Compare March 5, 2024 11:07
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

Pull request #44313 was updated. @mmusich, @cmsbuild, @Martin-Grunewald can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 5, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Mar 5, 2024

backport of #44311

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ca08d/37898/summary.html
COMMIT: 0871ebd
CMSSW: CMSSW_14_0_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44313/37898/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

  • You potentially added 83 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338820
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338789
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ca08d/37908/summary.html
COMMIT: 0871ebd
CMSSW: CMSSW_14_0_X_2024-03-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44313/37908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3338820
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338795
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3160f50 into cms-sw:CMSSW_14_0_X Mar 6, 2024
10 checks passed
@Martin-Grunewald Martin-Grunewald deleted the SpecialMenus_140X branch March 7, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants