Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of FOG special HLT menus [141X] #44311

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Mar 5, 2024

PR description:

Handling of FOG special HLT menus [141X]

https://its.cern.ch/jira/browse/CMSHLT-3092 : Completion of the offline "Special" table and lists of paths for individual special menus

See also discussion here:
https://docs.google.com/document/d/1XxsH3qXt7ZO4LIuwQg-I-Lp5rekkWsxSEG_Mwv1nh0Q/edit#heading=h.p0nxi1qdtn0t

PR validation:

Executing scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44311/39329

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

A new Pull Request was created by @Martin-Grunewald for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@missirol, @argiro, @thomreis, @silviodonato, @ReyerBand, @rchatter, @wang0jin this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44311/39330

  • This PR adds an extra 20KB to repository

@mmusich
Copy link
Contributor

mmusich commented Mar 5, 2024

@Martin-Grunewald we need to update this file:

compare_files $TABLES_AREA/online_pion.txt $TABLES_AREA/PIon.txt || die "Failure comparing online_pion and PIon" $?
compare_files $TABLES_AREA/online_hion.txt $TABLES_AREA/HIon.txt || die "Failure comparing online_hion and HIon" $?
compare_files $TABLES_AREA/online_pref.txt $TABLES_AREA/PRef.txt || die "Failure comparing online_pref and PRef" $?
compare_files $TABLES_AREA/online_cosmics.txt $TABLES_AREA/Special.txt || die "Failure comparing online_cosmics and Special" $?
compare_files $TABLES_AREA/online_special.txt $TABLES_AREA/Special.txt || die "Failure comparing online_special and Special" $?
compare_files $TABLES_AREA/online_grun.txt $TABLES_AREA/GRun.txt || die "Failure comparing online_grun and GRun" $?

with

diff --git a/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh b/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh
index ec10cbfdf10..73a9e19e2e6 100755
--- a/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh
+++ b/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh
@@ -70,6 +70,13 @@ TABLES_AREA="$CMSSW_BASE/src/HLTrigger/Configuration/tables"
 compare_files $TABLES_AREA/online_pion.txt $TABLES_AREA/PIon.txt || die "Failure comparing online_pion and PIon" $?
 compare_files $TABLES_AREA/online_hion.txt $TABLES_AREA/HIon.txt  || die "Failure comparing online_hion and HIon" $?
 compare_files $TABLES_AREA/online_pref.txt $TABLES_AREA/PRef.txt  || die "Failure comparing online_pref and PRef" $?
-compare_files $TABLES_AREA/online_cosmics.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_cosmics and Special" $?
-compare_files $TABLES_AREA/online_special.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_special and Special" $?
+compare_files $TABLES_AREA/online_Circulating.txt  $TABLES_AREA/Special.txt  || die "Failure comparing online_Circulating and Special" $?
+compare_files $TABLES_AREA/online_PPS.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_PPS and Special" $?
+compare_files $TABLES_AREA/online_LumiScan.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_LumiScan and Special" $?
+compare_files $TABLES_AREA/online_FirstCollisions.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_FirstCollisions and Special" $?
+compare_files $TABLES_AREA/online_ECALTiming.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_ECALTiming and Special" $?
+compare_files $TABLES_AREA/online_Cosmics.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_Cosmics and Special" $?
+compare_files $TABLES_AREA/online_TrackerVR.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_TrackerVR and Special" $?
+compare_files $TABLES_AREA/online_Splashes.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_Splashes and Special" $?
+compare_files $TABLES_AREA/online_Special.txt $TABLES_AREA/Special.txt  || die "Failure comparing online_Special and Special" $?
 compare_files $TABLES_AREA/online_grun.txt $TABLES_AREA/GRun.txt  || die "Failure comparing online_grun and GRun" $?

@mmusich mmusich force-pushed the SpecialMenus_141X branch from d595994 to ec2366a Compare March 5, 2024 11:05
@Martin-Grunewald
Copy link
Contributor Author

OK...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44311/39331

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

Pull request #44311 was updated. @mmusich, @cmsbuild, @Martin-Grunewald can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 5, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7f0b6/37899/summary.html
COMMIT: ec2366a
CMSSW: CMSSW_14_1_X_2024-03-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44311/37899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3339090
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3339065
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

@cms-sw/hlt-l2
Are these also automatically generated?
Are there corresponding JIRA tickets?

@Martin-Grunewald
Copy link
Contributor Author

@antoniovilela
I have updated the description of the PR with the single JIRA ticket.
The added files are used to create online menus for special running conditions (aka special menus) by containing the list of desired paths. These txt files are maintained by hand. The check is that the created menus contain the required paths.

@antoniovilela
Copy link
Contributor

@antoniovilela I have updated the description of the PR with the single JIRA ticket. The added files are used to create online menus for special running conditions (aka special menus) by containing the list of desired paths. These txt files are maintained by hand. The check is that the created menus contain the required paths.

Thanks.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c54e931 into cms-sw:master Mar 6, 2024
11 checks passed
@mmusich mmusich deleted the SpecialMenus_141X branch March 6, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants