-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of FOG special HLT menus [141X] #44311
Conversation
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44311/39329
|
A new Pull Request was created by @Martin-Grunewald for master. It involves the following packages:
@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44311/39330
|
@Martin-Grunewald we need to update this file:
with diff --git a/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh b/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh
index ec10cbfdf10..73a9e19e2e6 100755
--- a/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh
+++ b/HLTrigger/Configuration/test/test_OnlineVsDevTablesConsistency.sh
@@ -70,6 +70,13 @@ TABLES_AREA="$CMSSW_BASE/src/HLTrigger/Configuration/tables"
compare_files $TABLES_AREA/online_pion.txt $TABLES_AREA/PIon.txt || die "Failure comparing online_pion and PIon" $?
compare_files $TABLES_AREA/online_hion.txt $TABLES_AREA/HIon.txt || die "Failure comparing online_hion and HIon" $?
compare_files $TABLES_AREA/online_pref.txt $TABLES_AREA/PRef.txt || die "Failure comparing online_pref and PRef" $?
-compare_files $TABLES_AREA/online_cosmics.txt $TABLES_AREA/Special.txt || die "Failure comparing online_cosmics and Special" $?
-compare_files $TABLES_AREA/online_special.txt $TABLES_AREA/Special.txt || die "Failure comparing online_special and Special" $?
+compare_files $TABLES_AREA/online_Circulating.txt $TABLES_AREA/Special.txt || die "Failure comparing online_Circulating and Special" $?
+compare_files $TABLES_AREA/online_PPS.txt $TABLES_AREA/Special.txt || die "Failure comparing online_PPS and Special" $?
+compare_files $TABLES_AREA/online_LumiScan.txt $TABLES_AREA/Special.txt || die "Failure comparing online_LumiScan and Special" $?
+compare_files $TABLES_AREA/online_FirstCollisions.txt $TABLES_AREA/Special.txt || die "Failure comparing online_FirstCollisions and Special" $?
+compare_files $TABLES_AREA/online_ECALTiming.txt $TABLES_AREA/Special.txt || die "Failure comparing online_ECALTiming and Special" $?
+compare_files $TABLES_AREA/online_Cosmics.txt $TABLES_AREA/Special.txt || die "Failure comparing online_Cosmics and Special" $?
+compare_files $TABLES_AREA/online_TrackerVR.txt $TABLES_AREA/Special.txt || die "Failure comparing online_TrackerVR and Special" $?
+compare_files $TABLES_AREA/online_Splashes.txt $TABLES_AREA/Special.txt || die "Failure comparing online_Splashes and Special" $?
+compare_files $TABLES_AREA/online_Special.txt $TABLES_AREA/Special.txt || die "Failure comparing online_Special and Special" $?
compare_files $TABLES_AREA/online_grun.txt $TABLES_AREA/GRun.txt || die "Failure comparing online_grun and GRun" $? |
d595994
to
ec2366a
Compare
OK... |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44311/39331
|
Pull request #44311 was updated. @mmusich, @cmsbuild, @Martin-Grunewald can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7f0b6/37899/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/hlt-l2 |
@antoniovilela |
Thanks. |
+1 |
PR description:
Handling of FOG special HLT menus [141X]
https://its.cern.ch/jira/browse/CMSHLT-3092 : Completion of the offline "Special" table and lists of paths for individual special menus
See also discussion here:
https://docs.google.com/document/d/1XxsH3qXt7ZO4LIuwQg-I-Lp5rekkWsxSEG_Mwv1nh0Q/edit#heading=h.p0nxi1qdtn0t
PR validation:
Executing scripts
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 14_0