Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrimaryVertexProducer::fillDescriptions to generate a cfi file [140X] #44288

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

@Martin-Grunewald Martin-Grunewald commented Mar 3, 2024

PR description:

Fix PrimaryVertexProducer::fillDescriptions to generate a cfi file [140X].
Needed for ConfDb parsing.

PR validation:

The cfi file is now generated!

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44287 (to 14_0 as data taking release)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2024

A new Pull Request was created by @Martin-Grunewald for CMSSW_14_0_X.

It involves the following packages:

  • RecoVertex/PrimaryVertexProducer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@rovere, @VinInn, @VourMa, @missirol, @GiacomoSguazzoni, @mtosi, @dgulhan, @JanFSchulte, @mmusich this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

backport of #44287

@Martin-Grunewald
Copy link
Contributor Author

please test

@Martin-Grunewald
Copy link
Contributor Author

urgent

@Martin-Grunewald
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31604a/37864/summary.html
COMMIT: 9049a3d
CMSSW: CMSSW_14_0_X_2024-03-03-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44288/37864/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a25bfac into cms-sw:CMSSW_14_0_X Mar 4, 2024
10 checks passed
@Martin-Grunewald Martin-Grunewald deleted the fixPVP_140X branch March 7, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants