Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport of 43846 to 14_0_X] Primary vertex reconstruction: update configuration handling #44079

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

fabiocos
Copy link
Contributor

PR description:

Verbatim backport of #43846 into the 14_0_X branch, where the initial update of primary vertex reconstruction #43592 was merged.

PR validation:

Code cherry-picked with no conflict and compiled without problems from the original branch successfully integrated in 14_1_X .

commit 8b4a47e
Author: Fabio Cossutti <[email protected]>
Date:   Thu Feb 15 10:20:08 2024 +0100

    Restore original values, for phase2 4D no further overwriting by python

commit 8a0bedb
Author: Fabio Cossutti <[email protected]>
Date:   Wed Feb 14 14:00:23 2024 +0100

    Adopt a fillDescription default based python solution, with no explicit declaration where not strictly needed

commit 0b33159
Author: Fabio Cossutti <[email protected]>
Date:   Sun Feb 11 19:27:53 2024 +0100

    Apply suggestions from code review

    Co-authored-by: Matti Kortelainen <[email protected]>

commit a3e12cf
Author: Fabio Cossutti <[email protected]>
Date:   Fri Feb 9 17:30:57 2024 +0100

    Update RecoVertex/Configuration/python/RecoVertex_phase2_timing_cff.py

    Co-authored-by: Matti Kortelainen <[email protected]>

commit 324847b
Author: Fabio Cossutti <[email protected]>
Date:   Fri Feb 9 16:43:28 2024 +0100

    Update also RecoHI/HiTracking

commit 122b97c
Author: Fabio Cossutti <[email protected]>
Date:   Tue Feb 6 09:48:13 2024 +0100

    scram b code-format

commit aa62917
Author: Fabio Cossutti <[email protected]>
Date:   Tue Feb 6 09:33:05 2024 +0100

    Fix definition of TkFilterParameters

commit 8eea085
Author: Fabio Cossutti <[email protected]>
Date:   Fri Feb 2 15:01:16 2024 +0100

    Add a default PrimaryVertexProducer config including all possible options with ifValue
    Address Slava's comments on vertexCollections definition
    Add in fillDescription TkClusParameters conditional definition, xor for TkFilterParameters, do not build dynamically cfi but just use AddDefaults

commit 5f2258f
Author: Fabio Cossutti <[email protected]>
Date:   Mon Jan 29 16:37:00 2024 +0100

    Restore situation previous to RecoVertex/PrimaryVertexProducer configuration updates

Co-authored-by: Matti Kortelainen <[email protected]>
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

A new Pull Request was created by @fabiocos for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • RecoHI/HiTracking (reconstruction)
  • RecoVertex/Configuration (reconstruction)
  • RecoVertex/PrimaryVertexProducer (reconstruction)
  • Validation/RecoVertex (dqm)

@rvenditti, @mandrenguyen, @jfernan2, @syuvivida, @antoniovagnerini, @consuegs, @cmsbuild, @tjavaid, @saumyaphor4252, @nothingface0, @perrotta can you please review it and eventually sign? Thanks.
@kurtejung, @VourMa, @rovere, @VinInn, @jazzitup, @rsreds, @GiacomoSguazzoni, @missirol, @yetkinyilmaz, @JanFSchulte, @mmusich, @dgulhan, @yuanchao, @tlampen, @mandrenguyen, @mtosi, @yenjie, @tocheng, @venturia, @adewit, @felicepantaleo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

cms-bot internal usage

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad9f83/37669/summary.html
COMMIT: ca5c370
CMSSW: CMSSW_14_0_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44079/37669/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

+1

@tjavaid
Copy link

tjavaid commented Feb 27, 2024

backport of #43846

@perrotta
Copy link
Contributor

+1

@tjavaid
Copy link

tjavaid commented Feb 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a552a1a into cms-sw:CMSSW_14_0_X Feb 29, 2024
10 checks passed
@fabiocos fabiocos deleted the fc-fix_PV_config-140X branch March 1, 2024 07:59
@@ -451,7 +457,7 @@ void PrimaryVertexProducer::fillDescriptions(edm::ConfigurationDescriptions& des
desc.add<bool>("useMVACut", false);
desc.add<double>("minTrackTimeQuality", 0.8);

descriptions.add("primaryVertexProducer", desc);
descriptions.addDefault(desc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - ConfDb parsing needs an explicit cfi file. I assume you want descriptions.addWithDefaultLabel ?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #44288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants