Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Pythia8 photon flux #44258

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

backport of #43840

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024

A new Pull Request was created by @stahlleiton for CMSSW_13_0_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @GurpreetSinghChahal, @alberto-sanchez, @cmsbuild, @menglu21, @mkirsano, @bbilin can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 29, 2024

cms-bot internal usage

@stahlleiton
Copy link
Contributor Author

@hjbossi

@mandrenguyen
Copy link
Contributor

backport of #43840

@mandrenguyen
Copy link
Contributor

please test

@stahlleiton
Copy link
Contributor Author

Since this PR is meant for HIN MC production, should I also make a backport to CMSSW_13_0_HeavyIon_X ?

@mandrenguyen
Copy link
Contributor

@rappoccio @antoniovilela This one will eventually need to be added to a release to be built on top of CMSSW_13_0_HeavyIon

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84cd5b/37851/summary.html
COMMIT: 031e799
CMSSW: CMSSW_13_0_X_2024-02-25-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44258/37851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 239 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@hjbossi
Copy link
Contributor

hjbossi commented Mar 3, 2024

Could an authorized user please merge this request?

@mandrenguyen
Copy link
Contributor

Could an authorized user please merge this request?

We have to wait for @cms-sw/generators-l2 to sign

@DickyChant
Copy link

@menglu21 and @bbilin any news?

@menglu21
Copy link
Contributor

menglu21 commented Mar 6, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a48be6a into cms-sw:CMSSW_13_0_X Mar 7, 2024
10 checks passed
@stahlleiton stahlleiton deleted the pythia8PhotonFlux_13_0_X branch June 16, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants