Pythia8 photon flux

[hjbossi]

PR description:

This PR adds an option to the PYTHIA8 hadronizer in order to allow for the inclusion of a photon flux. This is needed for a centralized production for the analysis of charm production Photonuclear events for which some small private productions have already been made. For more information see here

PR validation:

All code compiles and has passed offline code checks. After checking with GEN coordinators we have also verified that code would not break nominal pythia setup. These tests as well as general information regarding the PR were discussed in the weekly HIN Forward PInG meeting .

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be backported to CMSSW_13_0_X which is the release meant for heavy ion production.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43840/38665

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43840/38665/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43840/38665/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43840/38666

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @hjbossi (Hannah Bossi) for master.

It involves the following packages:

• GeneratorInterface/Pythia8Interface (generators)

@cmsbuild, @SiewYan, @bbilin, @menglu21, @alberto-sanchez, @mkirsano, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[hjbossi]

Hi All,

Do we need to do anything else from our side to move this along? Please let us know.

Cheers,

Hannah

[menglu21]

+1

[hjbossi]

@menglu21 - I have added some protections so the tests should not fail and tested this locally, so we should be okay. If someone could issue the test command once possible that would be good.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43840/39007

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #43840 was updated. @alberto-sanchez, @mkirsano, @bbilin, @SiewYan, @cmsbuild, @menglu21, @GurpreetSinghChahal can you please check and sign again.

[hjbossi]

Following up on this - does someone mind issuing the test command?

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4d791/37660/summary.html
COMMIT: ba14235
CMSSW: CMSSW_14_1_X_2024-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43840/37660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245365
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3245340
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[hjbossi]

Hi All,

What is the next step in order to get this PR merged? We have checked it with local tests that this PR works fine with both the nominal workflow (not including the photon flux) and also the workflow for this use case (so with the photon flux). Thanks again for all of your help!

Cheers, Hannah

[menglu21]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1