[GEM][bug fix][backport] avoid the segmentation fault caused by the 2024 GEMGeometry

[yeckang]

PR description:

• With the 2024 GEMGeometry, the GEMPadDigiProducer trying to check the number of eta partitions from GE+2/1 chamber 1 layer 1.
• But the chamber dose not exist in the geometry. And it make a segmentation fault during the test.
• To avoid the problem, we asked the module to check GE+2/1 chamber 16 layer 2 which is in the geometry since 2022 instead of the ghost chamber.

PR validation:

• The change is tested with the customized geometry which is basically 2023 geometry, but changing gem21 to 2024 scenario.
• The code format passed with scram b code-format and scram b code-checks

@watson-ij @bsunanda

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

• The original PR is [GEM][bug fix] avoid the segmentation fault caused by the 2024 GEMGeometry #44083

[cmsbuild]

A new Pull Request was created by @yeckang for CMSSW_14_0_X.

It involves the following packages:

• L1Trigger/L1TGEM (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @JanFSchulte this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from [GEM][bug fix] avoid the segmentation fault caused by the 2024 GEMGeometry #44083

[cmsbuild]

cms-bot internal usage

[aloeliger]

backport of #44083

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-901239/37696/summary.html
COMMIT: ad9351c
CMSSW: CMSSW_14_0_X_2024-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44089/37696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 74 lines to the logs
• Reco comparison results: 72 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3245401
• DQMHistoTests: Total failures: 1195
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244184
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1