Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM][bug fix] avoid the segmentation fault caused by the 2024 GEMGeometry #44083

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

yeckang
Copy link
Contributor

@yeckang yeckang commented Feb 26, 2024

PR description:

  • With the 2024 GEMGeometry, the GEMPadDigiProducer trying to check the number of eta partitions from GE+2/1 chamber 1 layer 1.
  • But the chamber dose not exist in the geometry. And it make a segmentation fault during the test.
  • To avoid the problem, we asked the module to check GE+2/1 chamber 16 layer 2 which is in the geometry since 2022 instead of the ghost chamber.
  • A backport to CMSSW_14_0_X is needed.

PR validation:

  • The change is tested with the customized geometry which is basically 2023 geometry, but changing gem21 to 2024 scenario.
  • The code format passed with scram b code-format and scram b code-checks

@watson-ij @bsunanda

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44083/39049

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yeckang for master.

It involves the following packages:

  • L1Trigger/L1TGEM (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @JanFSchulte, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8867f3/37680/summary.html
COMMIT: e46916c
CMSSW: CMSSW_14_1_X_2024-02-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44083/37680/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 96 lines to the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3245365
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3245340
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a3adc2d into cms-sw:master Feb 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants