Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SoA collections ROOT read rules to classes.cc [14.0.x] #44022

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 20, 2024

PR description:

Technical, no changes expected.

Move the ROOT read rules of the SoA host collections for the ECAL digis, uncalibrated rechits, and PF rechits from classes_def.xml to classes.cc.

PR validation:

None.

Backport status

Backport of #44021 to 14.0.x for 2024 data taking.

Move the ROOT read rules for the ECAL digis SoA host collection from
classes_def.xml to classes.cc.
Move the ROOT read rules for the ECAL uncalibrated rechits SoA host collection
from classes_def.xml to classes.cc.
Move the ROOT read rules for the PF rechits SoA host collections from
classes_serial_def.xml to classes_serial.cc.
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Feb 20, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

backport #44021

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/EcalDigi (simulation)
  • DataFormats/EcalRecHit (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)

@mdhildreth, @civanch, @jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@argiro, @hatakeyamak, @wang0jin, @rovere, @missirol, @ReyerBand, @thomreis, @rchatter, @lgray this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

type ecal

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 20, 2024

type pf

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2035fd/37564/summary.html
COMMIT: aa411fa
CMSSW: CMSSW_14_0_X_2024-02-19-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44022/37564/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1496
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38244
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Feb 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b78dc35 into cms-sw:CMSSW_14_0_X Feb 26, 2024
13 checks passed
@fwyzard fwyzard deleted the update_SoA_dictionaries_140x branch March 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants