-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SoA collections ROOT read rules to classes.cc #44021
Conversation
Move the ROOT read rules for the ECAL digis SoA host collection from classes_def.xml to classes.cc.
Move the ROOT read rules for the ECAL uncalibrated rechits SoA host collection from classes_def.xml to classes.cc.
Move the ROOT read rules for the PF rechits SoA host collections from classes_serial_def.xml to classes_serial.cc.
enable gpu |
please test |
cms-bot internal usage |
type ecal |
type pf |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44021/38951
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@civanch, @jfernan2, @mandrenguyen, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fb213/37565/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Technical, no changes expected.
Move the ROOT read rules of the SoA host collections for the ECAL digis, uncalibrated rechits, and PF rechits from classes_def.xml to classes.cc.
PR validation:
None.
Backport status
To be backported to 14.0.x for 2024 data taking.