-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEM][backport] GEMGeometryBuilder update for the 2024 geometry #43991
[GEM][backport] GEMGeometryBuilder update for the 2024 geometry #43991
Conversation
…other region during 2024
A new Pull Request was created by @yeckang (Yechan Kang) for CMSSW_14_0_X. It involves the following packages:
@makortel, @bsunanda, @Dr15Jones, @subirsarkar, @cmsbuild, @civanch, @mdhildreth, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-927763/37517/summary.html Comparison SummarySummary:
|
+geometry |
@subirsarkar @srimanob Please approve this |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@antoniovilela, @rappoccio Please merge this. I need to use the IB to backport the next version (scenario definition) |
@bsunanda you need to stop tagging us for things within days of the PR being open. |
+1 |
PR description:
PR validation:
scram b code-format
andscram b code-checks
are appliedGEMGeometryAnalyzer
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: