-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEM] GEMGeometryBuilder update for the 2024 geometry #43948
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43948/38820
|
A new Pull Request was created by @yeckang (Yechan Kang) for master. It involves the following packages:
@civanch, @makortel, @srimanob, @Dr15Jones, @subirsarkar, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-477748/37398/summary.html Comparison SummarySummary:
|
@bsunanda , is it enough to enable extra GEM station? |
I am waiting to make a new scenario once I put up a version for the new RPC
…________________________________
From: Vladimir Ivantchenko ***@***.***>
Sent: 13 February 2024 21:49
To: cms-sw/cmssw ***@***.***>
Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***>
Subject: Re: [cms-sw/cmssw] [GEM] GEMGeometryBuilder update for the 2024 geometry (PR #43948)
@bsunanda<https://github.com/bsunanda> , is it enough to enable extra GEM station?
—
Reply to this email directly, view it on GitHub<#43948 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOQ33FAMTETE4KCTAI3YTOHAZAVCNFSM6AAAAABDF4P7V6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRHEZTGNZSGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
+1 @yeckang , please, try to make a backport of this PR to 14_0 |
@srimanob , please, review this PR |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@srimanob I don't expect any changes from any workflow. |
+1 |
PR description:
PR validation:
scram b code-format
andscram b code-checks
are appliedGEMGeometryAnalyzer
@watson-ij