Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM] GEMGeometryBuilder update for the 2024 geometry #43948

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

yeckang
Copy link
Contributor

@yeckang yeckang commented Feb 13, 2024

PR description:

  • The GE2/1 demonstrator was installed at the beginning of Run 3.
  • At the beginning of the year, we installed the 2 GE 2/1 production chambers on the other region of the demonstrator.
  • @bsunanda made the GEM geometry for 2024. (Run3-gex175 Try to have the 2024 version of GE21 #43876).
  • On the testing for the new geometry, the demonstrator is not built with the new 2 production chambers.
  • This PR allows the building of the demonstrator with the 2 new chambers.

PR validation:

  • scram b code-format and scram b code-checks are applied
  • The built geometry has been tested with GEMGeometryAnalyzer

@watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43948/38820

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yeckang (Yechan Kang) for master.

It involves the following packages:

  • Geometry/GEMGeometryBuilder (upgrade, geometry)

@civanch, @makortel, @srimanob, @Dr15Jones, @subirsarkar, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@watson-ij, @giovanni-mocellin, @fabiocos, @slomeo, @bsunanda, @jshlee this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@watson-ij
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-477748/37398/summary.html
COMMIT: c4711e6
CMSSW: CMSSW_14_1_X_2024-02-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43948/37398/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor

civanch commented Feb 13, 2024

@bsunanda , is it enough to enable extra GEM station?

@bsunanda
Copy link
Contributor

bsunanda commented Feb 14, 2024 via email

@civanch
Copy link
Contributor

civanch commented Feb 14, 2024

+1

@yeckang , please, try to make a backport of this PR to 14_0

@civanch
Copy link
Contributor

civanch commented Feb 14, 2024

@srimanob , please, review this PR

@srimanob
Copy link
Contributor

@yeckang what do I expect from this PR? No change in any workflow?

Note that, @cms-sw/alca-l2 @cms-sw/pdmv-l2 PR test have not moved to 2024. Should it be moved? For example, #43876 is XML of 2024, so we did not really test it until we have it in GT. Thx.

@saumyaphor4252
Copy link
Contributor

Note that, @cms-sw/alca-l2 @cms-sw/pdmv-l2 PR test have not moved to 2024. Should it be moved? For example, #43876 is XML of 2024, so we did not really test it until we have it in GT. Thx.

We'll start updating the GT as soon as we have the tags/payloads from @bsunanda

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

srimanob commented Feb 14, 2024

Converging with @civanch that this PR can be signed. No change is expected, but @yeckang please confirm, also prepare the backport to 14_0.

@yeckang
Copy link
Contributor Author

yeckang commented Feb 15, 2024

@srimanob I don't expect any changes from any workflow.
I will prepare the backport.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2a3645c into cms-sw:master Feb 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants