[Phase-2 L1T 14_0_X] small fixes for RCT cluster emulation

[pallabidas]

PR description:

Small changes to correctly use ECAL LSB = 0.5 in firmware based code. A fix in RCT cluster stitching function and shower shape flag is implemented.

PR validation:

Passes local validation checks with efficiency and rate plots, to be presented in a DP note.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR: #43950
We need the backport for 14_0_X

[cmsbuild]

A new Pull Request was created by @pallabidas (Pallabi Das) for CMSSW_14_0_X.

It involves the following packages:

• L1Trigger/L1CaloTrigger (l1, upgrade)

@subirsarkar, @aloeliger, @srimanob, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from [Phase-2 L1T] small fixes for RCT cluster emulation #43950

[cmsbuild]

cms-bot internal usage

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3d0a6/37518/summary.html
COMMIT: 3908b8e
CMSSW: CMSSW_14_0_X_2024-02-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43989/37518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 105 lines to the logs
• Reco comparison results: 43 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248626
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248598
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[aloeliger]

Backport of #43950

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1