[Phase-2 L1T] small fixes for RCT cluster emulation #43950

pallabidas · 2024-02-13T15:58:46Z

PR description:

Small changes to correctly use ECAL LSB = 0.5 in firmware based code. A fix in RCT cluster stitching function and shower shape flag is implemented.

Also being reviewed here: cms-l1t-offline#1206

PR validation:

Passes local validation checks with efficiency and rate plots, to be presented in a DP note.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

not a backport

@aloeliger @epalencia

cmsbuild · 2024-02-13T15:59:10Z

cms-bot internal usage

cmsbuild · 2024-02-13T16:04:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43950/38827

This PR adds an extra 48KB to repository

cmsbuild · 2024-02-13T16:04:34Z

A new Pull Request was created by @pallabidas (Pallabi Das) for master.

It involves the following packages:

L1Trigger/L1CaloTrigger (upgrade, l1)

@srimanob, @subirsarkar, @cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

epalencia · 2024-02-13T18:44:03Z

Please test

cmsbuild · 2024-02-14T00:42:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-121b07/37433/summary.html
COMMIT: ab2362e
CMSSW: CMSSW_14_1_X_2024-02-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43950/37433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
Reco comparison results: 56 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248523
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

srimanob · 2024-02-14T01:22:30Z

L1Trigger/L1CaloTrigger/interface/Phase2L1CaloEGammaUtils.h

    bool is_ss;
    if (pt > 130)
      is_ss = true;
+    else if ((abs(eta) > 0.4 && abs(eta) < 0.5) || (abs(eta) > 0.75 && abs(eta) < 0.85))  // temporary adjustment
+      is_ss = ((loose_ss_offset + c1_ss * std::exp(-c2_ss * pt)) <= ss);


This part contains many magic numbers, including pt cut above. Is it possible to define them as constexpr float before?

@srimanob done

cmsbuild · 2024-02-14T12:08:53Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43950/38853

This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43950/38853/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43950/38853/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-02-14T12:29:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43950/38854

This PR adds an extra 48KB to repository

cmsbuild · 2024-02-14T12:30:10Z

Pull request #43950 was updated. @cmsbuild, @srimanob, @aloeliger, @epalencia, @subirsarkar can you please check and sign again.

epalencia · 2024-02-14T13:53:37Z

Please test

cmsbuild · 2024-02-14T17:06:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-121b07/37458/summary.html
COMMIT: 3908b8e
CMSSW: CMSSW_14_1_X_2024-02-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43950/37458/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 20 lines to the logs
Reco comparison results: 68 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248554
DQMHistoTests: Total failures: 1195
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247337
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

aloeliger · 2024-02-15T12:40:53Z

+l1

Already merged in l1 fork as part of phase 2 prototype

srimanob · 2024-02-15T12:50:23Z

+Upgrade

srimanob · 2024-02-15T12:50:48Z

Do we need a backport to 14_0?

cmsbuild · 2024-02-15T12:50:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

pallabidas · 2024-02-15T13:02:08Z

Hi @srimanob we would like this to be included in the new samples, so yes for backport to 14_0

antoniovilela · 2024-02-18T06:55:06Z

+1

small fixes for RCT cluster emulation

ab2362e

pallabidas changed the title ~~small fixes for RCT cluster emulation~~ [Phase-2 L1T] small fixes for RCT cluster emulation Feb 13, 2024

cmsbuild added this to the CMSSW_14_1_X milestone Feb 13, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Feb 13, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 13, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 13, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 14, 2024

srimanob reviewed Feb 14, 2024

View reviewed changes

define constexpr for pt and eta thresholds

27cd7bb

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Feb 14, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 14, 2024

code-format fix

3908b8e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 14, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 14, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 14, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 14, 2024

cmsbuild added l1-approved and removed l1-pending labels Feb 15, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Feb 15, 2024

pallabidas mentioned this pull request Feb 15, 2024

[Phase-2 L1T 14_0_X] small fixes for RCT cluster emulation #43989

Merged

cmsbuild added orp-approved and removed orp-pending labels Feb 18, 2024

cmsbuild merged commit cd2e4ee into cms-sw:master Feb 18, 2024
21 checks passed

cmsbuild mentioned this pull request Feb 18, 2024

Enable TF XLA, add tensorflow-xla-runtime. cms-sw/cmsdist#9005

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Phase-2 L1T] small fixes for RCT cluster emulation #43950

[Phase-2 L1T] small fixes for RCT cluster emulation #43950

pallabidas commented Feb 13, 2024

cmsbuild commented Feb 13, 2024 •

edited

Loading

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 13, 2024

epalencia commented Feb 13, 2024

cmsbuild commented Feb 14, 2024

srimanob Feb 14, 2024

pallabidas Feb 14, 2024

cmsbuild commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

epalencia commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

aloeliger commented Feb 15, 2024

srimanob commented Feb 15, 2024

srimanob commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

pallabidas commented Feb 15, 2024

antoniovilela commented Feb 18, 2024

[Phase-2 L1T] small fixes for RCT cluster emulation #43950

[Phase-2 L1T] small fixes for RCT cluster emulation #43950

Conversation

pallabidas commented Feb 13, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Feb 13, 2024 • edited Loading

cmsbuild commented Feb 13, 2024

cmsbuild commented Feb 13, 2024

epalencia commented Feb 13, 2024

cmsbuild commented Feb 14, 2024

Comparison Summary

srimanob Feb 14, 2024

Choose a reason for hiding this comment

pallabidas Feb 14, 2024

Choose a reason for hiding this comment

cmsbuild commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

epalencia commented Feb 14, 2024

cmsbuild commented Feb 14, 2024

Comparison Summary

aloeliger commented Feb 15, 2024

srimanob commented Feb 15, 2024

srimanob commented Feb 15, 2024

cmsbuild commented Feb 15, 2024

pallabidas commented Feb 15, 2024

antoniovilela commented Feb 18, 2024

cmsbuild commented Feb 13, 2024 •

edited

Loading