Simplify definition of PortableMultiCollection<TDev, ...>, and allow it to be used outside of ALPAKA_ACCELERATOR_NAMESPACE

[makortel]

PR description:

I.e. repeat #43310 on PortableMultiCollection (that was added in #40285).

PR validation:

Unit tests run.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43983/38897

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/Portable/test/portableObjectOnHost.cc modified in PR(s): Add {Copy,Move}ToDeviceCache<T> class templates and moveToDeviceAsync function template #43969

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• DataFormats/Portable (heterogeneous)

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

enable gpu

[makortel]

@cmsbuild, please test

[makortel]

@fwyzard @ericcano Any objections? (this PR follows the same pattern as #43310 did for PortableCollection and PortableObject)

I suppose this PR should be backported to 14_0_X as well?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58fc51/37503/summary.html
COMMIT: 9dc4cd5
CMSSW: CMSSW_14_1_X_2024-02-15-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43983/37503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 97 lines from the logs
• Reco comparison results: 62 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 1192
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247340
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially added 12 lines to the logs
• Reco comparison results: 33 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 753
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38987
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[makortel]

Comparisons show the usual

• spurious differences in outputs of Run-3 wfs *.7 #39803
• Non reproducibility in wf 136.793 #43293
• Non-reproducibility in TriggerResults in 24834.0, 24834.911, and 25034.999 #43790

[fwyzard]

@fwyzard @ericcano Any objections? (this PR follows the same pattern as #43310 did for PortableCollection and PortableObject)

No objections from me: I just skimmed through the changes, and I trust you on the design :-)

I suppose this PR should be backported to 14_0_X as well?

Yes, please.

(btw, I guess we have already given up on trying to use a single branch for 14.0.x and 14.1.x developments)

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

I suppose this PR should be backported to 14_0_X as well?

Yes, please.

Done in #44014

(btw, I guess we have already given up on trying to use a single branch for 14.0.x and 14.1.x developments)

I'd assume so too.

[rappoccio]

+1